netdev - Re: [PATCH net-next 3/4] ynl: regenerate all headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKH8qBvix3YLwrFjMspk3Wttc=CfYW5xJgQt86x2Jg98v2Y55w@mail.gmail.com>
Date: Wed, 26 Jul 2023 16:55:07 -0700
From: Stanislav Fomichev <sdf@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com, 
	pabeni@...hat.com
Subject: Re: [PATCH net-next 3/4] ynl: regenerate all headers

On Wed, Jul 26, 2023 at 4:37 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Tue, 25 Jul 2023 16:35:16 -0700 Stanislav Fomichev wrote:
> > Also add small (and simple - no dependencies) makefile rule do update
> > the UAPI ones.
>
> I was thinking people would use:
>
> ./tools/net/ynl/ynl-regen.sh -f
>
> for this. It is slightly more capable. Can we perhaps hook the new make
> target to just run that script?

Oh, didn't know about this. Something like this maybe? Ugly?

diff --git a/tools/net/ynl/Makefile b/tools/net/ynl/Makefile
index d664b36deb5b..c36380bf1536 100644
--- a/tools/net/ynl/Makefile
+++ b/tools/net/ynl/Makefile
@@ -3,6 +3,7 @@
 SUBDIRS = lib generated samples

 all: $(SUBDIRS)
+       (cd ../../../ && ./tools/net/ynl/ynl-regen.sh -f)

 $(SUBDIRS):
        @if [ -f "$@...kefile" ] ; then \

Or, now that I know about the script I can actually run it manually.
But with a makefile imo a bit easier to discover..