netdev - Re: [PATCH 1/1] qed: Fix scheduling in a tasklet while getting stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZMJcDvPrz1pEBPft@corigine.com>
Date: Thu, 27 Jul 2023 13:59:10 +0200
From: Simon Horman <simon.horman@...igine.com>
To: Konstantin Khorenko <khorenko@...tuozzo.com>
Cc: netdev@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>,
	Manish Chopra <manishc@...vell.com>,
	Ariel Elior <aelior@...vell.com>,
	David Miller <davem@...emloft.net>,
	Sudarsana Kalluru <skalluru@...vell.com>,
	Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH 1/1] qed: Fix scheduling in a tasklet while getting stats

On Wed, Jul 26, 2023 at 08:19:30PM +0300, Konstantin Khorenko wrote:

...

> diff --git a/drivers/net/ethernet/qlogic/qed/qed_iscsi.h b/drivers/net/ethernet/qlogic/qed/qed_iscsi.h
> index dec2b00259d4..7d8d6ad7faa9 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_iscsi.h
> +++ b/drivers/net/ethernet/qlogic/qed/qed_iscsi.h
> @@ -43,7 +43,8 @@ void qed_iscsi_free(struct qed_hwfn *p_hwfn);
>   * Return: Void.
>   */
>  void qed_get_protocol_stats_iscsi(struct qed_dev *cdev,
> -				  struct qed_mcp_iscsi_stats *stats);
> +				  struct qed_mcp_iscsi_stats *stats,
> +				  bool is_atomic);

Hi Konstantin,

Please add is_atomic to the kernel doc for qed_get_protocol_stats_iscsi,
which is immediately above this function declaration.

>  #else /* IS_ENABLED(CONFIG_QED_ISCSI) */
>  static inline int qed_iscsi_alloc(struct qed_hwfn *p_hwfn)
>  {
> @@ -56,7 +57,8 @@ static inline void qed_iscsi_free(struct qed_hwfn *p_hwfn) {}
>  
>  static inline void
>  qed_get_protocol_stats_iscsi(struct qed_dev *cdev,
> -			     struct qed_mcp_iscsi_stats *stats) {}
> +			     struct qed_mcp_iscsi_stats *stats,
> +			     bool is_atomic) {}
>  #endif /* IS_ENABLED(CONFIG_QED_ISCSI) */
>  
>  #endif

-- 
pw-bot: changes-requested