netdev - Re: [PATCH -next] net: bcmasp: Clean up redundant dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZMJx8JnLPBbsR1Up@corigine.com>
Date: Thu, 27 Jul 2023 15:32:32 +0200
From: Simon Horman <simon.horman@...igine.com>
To: Chen Jiahao <chenjiahao16@...wei.com>
Cc: justin.chen@...adcom.com, florian.fainelli@...adcom.com,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, bcm-kernel-feedback-list@...adcom.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH -next] net: bcmasp: Clean up redundant dev_err_probe()

On Thu, Jul 27, 2023 at 07:55:51PM +0800, Chen Jiahao wrote:
> Refering to platform_get_irq()'s definition, the return value has

nit: Refering -> Referring

> already been checked, error message also been printed via
> dev_err_probe() if ret < 0. Calling dev_err_probe() one more time
> outside platform_get_irq() is obviously redundant.
> 
> Removing dev_err_probe() outside platform_get_irq() to clean up
> above problem.
> 
> Signed-off-by: Chen Jiahao <chenjiahao16@...wei.com>

Reviewed-by: Simon Horman <simon.horman@...igine.com>