netdev - Re: [PATCH net-next 0/7] mlxsw: Avoid non-tracker helpers when holding and putting netdevices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89i+09tRSQWA85KR-3wTAPZk4_-nzrezYowcKA4anFoNCEQ@mail.gmail.com>
Date: Thu, 27 Jul 2023 19:02:03 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: Petr Machata <petrm@...dia.com>
Cc: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org, 
	Ido Schimmel <idosch@...dia.com>, mlxsw@...dia.com
Subject: Re: [PATCH net-next 0/7] mlxsw: Avoid non-tracker helpers when
 holding and putting netdevices

On Thu, Jul 27, 2023 at 6:00 PM Petr Machata <petrm@...dia.com> wrote:
>
> Using the tracking helpers, netdev_hold() and netdev_put(), makes it easier
> to debug netdevice refcount imbalances when CONFIG_NET_DEV_REFCNT_TRACKER
> is enabled. For example, the following traceback shows the callpath to the
> point of an outstanding hold that was never put:
>
>     unregister_netdevice: waiting for swp3 to become free. Usage count = 6
>     ref_tracker: eth%d@...f888123c9a580 has 1/5 users at
>         mlxsw_sp_switchdev_event+0x6bd/0xcc0 [mlxsw_spectrum]
>         notifier_call_chain+0xbf/0x3b0
>         atomic_notifier_call_chain+0x78/0x200
>         br_switchdev_fdb_notify+0x25f/0x2c0 [bridge]
>         fdb_notify+0x16a/0x1a0 [bridge]
>         [...]
>
> In this patchset, get rid of all non-ref-tracking helpers in mlxsw.

For the series :

Reviewed-by: Eric Dumazet <edumazet@...gle.com>