netdev - Re: [PATCH net] bnxt: don't handle XDP in netpoll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230727120522.392fe60b@kernel.org>
Date: Thu, 27 Jul 2023 12:05:22 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Michael Chan <michael.chan@...adcom.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com, gospo@...adcom.com
Subject: Re: [PATCH net] bnxt: don't handle XDP in netpoll

On Thu, 27 Jul 2023 11:52:10 -0700 Michael Chan wrote:
> These TX packet completions have already been counted in
> __bnxt_poll_work().  If we do nothing here, I think the TX ring will
> forever be out-of-sync with the completion ring.

I see...

Do you prefer adding a return value to tx_int() to tell
__bnxt_poll_work_done() whether the work has been done;
or to clear tx_pkts in the handler itself rather than
the caller?