netdev - Re: [PATCH -next] net: bcmasp: Clean up redundant dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48ecd30c-fdb8-c987-7369-78664ea4f799@huawei.com>
Date: Fri, 28 Jul 2023 16:11:44 +0800
From: "chenjiahao (C)" <chenjiahao16@...wei.com>
To: Simon Horman <simon.horman@...igine.com>
CC: <justin.chen@...adcom.com>, <florian.fainelli@...adcom.com>,
	<davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
	<pabeni@...hat.com>, <bcm-kernel-feedback-list@...adcom.com>,
	<netdev@...r.kernel.org>
Subject: Re: [PATCH -next] net: bcmasp: Clean up redundant dev_err_probe()


On 2023/7/27 21:32, Simon Horman wrote:
> On Thu, Jul 27, 2023 at 07:55:51PM +0800, Chen Jiahao wrote:
>> Refering to platform_get_irq()'s definition, the return value has
> nit: Refering -> Referring

Thanks, I will fix this typo in v2 patch if needed.

Jiahao

>
>> already been checked, error message also been printed via
>> dev_err_probe() if ret < 0. Calling dev_err_probe() one more time
>> outside platform_get_irq() is obviously redundant.
>>
>> Removing dev_err_probe() outside platform_get_irq() to clean up
>> above problem.
>>
>> Signed-off-by: Chen Jiahao <chenjiahao16@...wei.com>
> Reviewed-by: Simon Horman <simon.horman@...igine.com>
>