netdev - RE: Re: [PATCH v2 net-next] dissector: Use 64bits for used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: 
 <MWHPR1801MB1918661082BC3328EAE37071D306A@MWHPR1801MB1918.namprd18.prod.outlook.com>
Date: Fri, 28 Jul 2023 10:09:29 +0000
From: Ratheesh Kannoth <rkannoth@...vell.com>
To: Petr Machata <petrm@...dia.com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com"
	<edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>
Subject: RE:  Re: [PATCH v2 net-next] dissector: Use 64bits for used_keys

> -----Original Message-----
> From: Petr Machata <petrm@...dia.com>
> Sent: Friday, July 28, 2023 3:00 PM
> Subject: [EXT] Re: [PATCH v2 net-next] dissector: Use 64bits for used_keys
> 
> > Signed-off-by: Ratheesh Kannoth <rkannoth@...vell.com>
> > Reviewed-by: Petr Machata <petrm@...dia.com>
> 
> This makes it look like I reviewed the whole thing. I think I wrote
> this:
> 
> 	Reviewed-by: Petr Machata <petrm@...dia.com> # for mlxsw
I did not see any  instances of adding like  # "text".  If it is valid style, I will fix it in next Patch. 

> Also, you either missed or ignored my proposal for subject line update.
> I do think that "net: flow_dissector:" would be a better prefix, because that's
> how the component is called, and it's in the net namespace. It's OK not to
> agree, but in that case please argue to that end.

My bad.  I missed it. I will address in next patch.