netdev - Re: [PATCH net-next 2/2] net: phy: add keep_data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 28 Jul 2023 11:48:36 +0200
From: Andrew Lunn <andrew@...n.ch>
To: "mengyuanlou@...-swift.com" <mengyuanlou@...-swift.com>
Cc: Jakub Kicinski <kuba@...nel.org>,
	"Russell King (Oracle)" <linux@...linux.org.uk>,
	Simon Horman <simon.horman@...igine.com>, netdev@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>,
	Heiner Kallweit <hkallweit1@...il.com>
Subject: Re: [PATCH net-next 2/2] net: phy: add keep_data_connection to
 struct phydev

> > All of this is usually in FW so we should be able to shape the
> > implementation in the way we want...
> > 
> We certainly can do all phy operations in Fw when we are using NCSI.

I would actually prefer Linux does it, not firmware. My personal
preference is also Linux driver the hardware, since it is then
possible for the community to debug it, extend it with new
functionality, etc. Firmware is a black box only the vendor can do
anything with.

But as Jakub points out, we are entering a new territory here with
your device. All the other host devices which support NCSI have
firmware driving the hardware, not Linux. This is why you cannot find
code to copy. You need to actually write the host side of the NCSI
protocol, and figure out what the API to phylink should be, etc.

	Andrew