netdev - Re: [PATCH v2 03/10] net: stmmac: dwmac1000: Add multi-channel support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACWXhKm9Qu3CUjGpqa_5dx74MDVHODKVrsotTi0+V03zDBVqwg@mail.gmail.com>
Date: Fri, 28 Jul 2023 09:51:40 +0800
From: Feiyang Chen <chris.chenfeiyang@...il.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: Feiyang Chen <chenfeiyang@...ngson.cn>, hkallweit1@...il.com, peppe.cavallaro@...com, 
	alexandre.torgue@...s.st.com, joabreu@...opsys.com, chenhuacai@...ngson.cn, 
	linux@...linux.org.uk, dongbiao@...ngson.cn, 
	loongson-kernel@...ts.loongnix.cn, netdev@...r.kernel.org, 
	loongarch@...ts.linux.dev
Subject: Re: [PATCH v2 03/10] net: stmmac: dwmac1000: Add multi-channel support

On Thu, Jul 27, 2023 at 5:01 PM Andrew Lunn <andrew@...n.ch> wrote:
>
> On Thu, Jul 27, 2023 at 03:15:46PM +0800, Feiyang Chen wrote:
> > Some platforms have dwmac1000 implementations that support multi-
> > channel. Extend the functions to add multi-channel support.
> >
> > +     priv->plat->dwmac_is_loongson = false;
>
> I don't know this driver, so my comments could be wrong...
>
> Is this specific to loongson, or multi-channel? If you look at the
> other bool in plat, they are all for features, not machines? Could
> this actually be called priv->multi_chan_en ?
>

Hi, Andrew,

It is specific to loongson. I think I can add some features instead of
using dwmac_is_loongson.

Thanks,
Feiyang

>      Andrew