netdev - RE: [PATCH net-next 1/2] net: Keep sk->sk_forward

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CH3PR11MB7345C15CA3D7C5E630BF1353FC06A@CH3PR11MB7345.namprd11.prod.outlook.com>
Date: Fri, 28 Jul 2023 02:26:45 +0000
From: "Zhang, Cathy" <cathy.zhang@...el.com>
To: Shakeel Butt <shakeelb@...gle.com>, Eric Dumazet <edumazet@...gle.com>,
	Andrew Morton <akpm@...ux-foundation.org>
CC: "Sang, Oliver" <oliver.sang@...el.com>, "Yin, Fengwei"
	<fengwei.yin@...el.com>, "Tang, Feng" <feng.tang@...el.com>, Linux MM
	<linux-mm@...ck.org>, Cgroups <cgroups@...r.kernel.org>, Paolo Abeni
	<pabeni@...hat.com>, "davem@...emloft.net" <davem@...emloft.net>,
	"kuba@...nel.org" <kuba@...nel.org>, "Brandeburg, Jesse"
	<jesse.brandeburg@...el.com>, "Srinivas, Suresh" <suresh.srinivas@...el.com>,
	"Chen, Tim C" <tim.c.chen@...el.com>, "You, Lizhen" <lizhen.you@...el.com>,
	"eric.dumazet@...il.com" <eric.dumazet@...il.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "Li, Philip" <philip.li@...el.com>, "Liu, Yujie"
	<yujie.liu@...el.com>
Subject: RE: [PATCH net-next 1/2] net: Keep sk->sk_forward_alloc as a proper
 size

 
> The hierarchical nature of memcg makes that a bit complicated. We have
> something similar for memcg stats which is rstat infra where the stats are
> saved per-memcg per-cpu and get accumulated hierarchically every 2
> seconds. This works fine for stats but for limits there would be a need for
> some additional restrictions.
> 
> Also sometime ago Andrew asked me to explore replacing the atomic counter
> in page_counter with percpu_counter. Intuition is that most of the time the
> usage is not hitting the limit, so we can use __percpu_counter_compare for
> enforcement.
> 
> Let me spend some time to explore per-memcg per-cpu cache or if
> percpu_counter would be better.

Greetings Shakeel,

Hope this message finds you well. I want to inquiry about the current status of
the fixing. Have you completed the evaluation and started working on the final
solution?

> 
> For now, this patch is more like an RFC.