netdev - Re: [PATCH] net: netsec: Ignore 'phy-mode' on SynQuacer in DT mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8ed87590-4f0e-423a-a326-c4f6bef24596@sirena.org.uk>
Date: Fri, 28 Jul 2023 18:11:43 +0100
From: Mark Brown <broonie@...nel.org>
To: Andrew Lunn <andrew@...n.ch>
Cc: Masahisa Kojima <masahisa.kojima@...aro.org>,
	Ard Biesheuvel <ardb@...nel.org>,
	Jassi Brar <jaswinder.singh@...aro.org>,
	Ilias Apalodimas <ilias.apalodimas@...aro.org>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: netsec: Ignore 'phy-mode' on SynQuacer in DT mode

On Fri, Jul 28, 2023 at 07:07:36PM +0200, Andrew Lunn wrote:
> On Fri, Jul 28, 2023 at 09:35:00PM +0900, Masahisa Kojima wrote:

> > "rgmii-id" is correct, configured by board level.
> > The latest EDK2 firmware was already modified to use the correct value
> > for DT(Thank you, Ard).
> > http://snapshots.linaro.org/components/kernel/leg-96boards-developerbox-edk2/100/

Thanks, that does seem to be working.

> If the firmware has been fixed, i would actually do something like:

> 	err = of_get_phy_mode(pdev->dev.of_node, &priv->phy_interface);
> 	if (err)
> 		return err;

> 	if (of_machine_is_compatible("socionext,developer-box") &&
> 	    priv->phy_interface != PHY_INTERFACE_MODE_RGMII_ID) {
> 	    	pr_warn(FW_WARN, "Working around broken firmware. Please upgrade your firmware");
> 		priv->phy_interface = PHY_INTERFACE_MODE_RGMII_ID;
> 	}

It is not clear to me that the release channels for this firmware are
sufficiently clear to users for this to be constructive.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)