netdev - Re: selftests: connector: proc_filter.c:48:20: error: invalid application of 'sizeof' to an incomplete type 'struct proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <264B7DFC-D343-476E-ADA9-86FAF708FE87@oracle.com>
Date: Fri, 28 Jul 2023 18:08:52 +0000
From: Anjali Kulkarni <anjali.k.kulkarni@...cle.com>
To: Shuah Khan <skhan@...uxfoundation.org>
CC: Jakub Kicinski <kuba@...nel.org>,
        Naresh Kamboju
	<naresh.kamboju@...aro.org>,
        "open list:KERNEL SELFTEST FRAMEWORK"
	<linux-kselftest@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        "lkft-triage@...ts.linaro.org" <lkft-triage@...ts.linaro.org>,
        Netdev
	<netdev@...r.kernel.org>,
        clang-built-linux <llvm@...ts.linux.dev>,
        Shuah
 Khan <shuah@...nel.org>,
        Anders Roxell <anders.roxell@...aro.org>,
        "David S.
 Miller" <davem@...emloft.net>,
        Liam Howlett <liam.howlett@...cle.com>
Subject: Re: selftests: connector: proc_filter.c:48:20: error: invalid
 application of 'sizeof' to an incomplete type 'struct proc_input'



> On Jul 28, 2023, at 10:34 AM, Shuah Khan <skhan@...uxfoundation.org> wrote:
> 
> On 7/28/23 10:46, Anjali Kulkarni wrote:
>>> On Jul 27, 2023, at 7:43 PM, Jakub Kicinski <kuba@...nel.org> wrote:
>>> 
>>> On Fri, 28 Jul 2023 01:38:40 +0000 Anjali Kulkarni wrote:
>>>> Jakub,
>>>> Do I need to revert the -f runtime filter option back to compile time
>>>> and commit with that disabled so the selftest compiles on a kernel on
>>>> which the new options are not defined?
>>> 
>>> I'm not 100% sure myself on what's the expectations for building
>>> selftests against uAPI headers is..
>>> 
>>> I _think_ that you're supposed to add an -I$something to
>>> the CFLAGS in your Makefile. KHDR_INCLUDES maybe? So that the uAPI
>>> headers from the build get used (rendered by make headers).
>>> 
>>> Take a look at Documentation/dev-tools/kselftest.rst, I hope
>>> the answer is somewhere there.
>> Ok thanks, I will look into your suggestions.
>> Anjali
> 
> I sent a 3 patch series with the fix to this problem and a couple of
> others I found during testing.
> 

I was just about to send the fix, but thanks.

Anjali

> thanks,
> -- Shuah