netdev - Re: [PATCH bpf-next v4 13/21] ice: Implement checksum hint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202307290459.rfUV5NZw-lkp@intel.com>
Date: Sat, 29 Jul 2023 05:02:25 +0800
From: kernel test robot <lkp@...el.com>
To: Larysa Zaremba <larysa.zaremba@...el.com>, bpf@...r.kernel.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	Larysa Zaremba <larysa.zaremba@...el.com>, ast@...nel.org,
	daniel@...earbox.net, andrii@...nel.org, martin.lau@...ux.dev,
	song@...nel.org, yhs@...com, john.fastabend@...il.com,
	kpsingh@...nel.org, sdf@...gle.com, haoluo@...gle.com,
	jolsa@...nel.org, David Ahern <dsahern@...il.com>,
	Jakub Kicinski <kuba@...nel.org>,
	Willem de Bruijn <willemb@...gle.com>,
	Jesper Dangaard Brouer <brouer@...hat.com>,
	Anatoly Burakov <anatoly.burakov@...el.com>,
	Alexander Lobakin <alexandr.lobakin@...el.com>,
	Magnus Karlsson <magnus.karlsson@...il.com>,
	Maryam Tahhan <mtahhan@...hat.com>, xdp-hints@...-project.net,
	netdev@...r.kernel.org,
	Alexei Starovoitov <alexei.starovoitov@...il.com>,
	Simon Horman <simon.horman@...igine.com>
Subject: Re: [PATCH bpf-next v4 13/21] ice: Implement checksum hint

Hi Larysa,

kernel test robot noticed the following build warnings:

[auto build test WARNING on bpf-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Larysa-Zaremba/ice-make-RX-HW-timestamp-reading-code-more-reusable/20230729-023952
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
patch link:    https://lore.kernel.org/r/20230728173923.1318596-14-larysa.zaremba%40intel.com
patch subject: [PATCH bpf-next v4 13/21] ice: Implement checksum hint
config: i386-randconfig-i012-20230728 (https://download.01.org/0day-ci/archive/20230729/202307290459.rfUV5NZw-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce: (https://download.01.org/0day-ci/archive/20230729/202307290459.rfUV5NZw-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307290459.rfUV5NZw-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/net/ethernet/intel/ice/ice_txrx_lib.c:674: warning: expecting prototype for ice_xdp_rx_csum_lvl(). Prototype was for ice_xdp_rx_csum() instead


vim +674 drivers/net/ethernet/intel/ice/ice_txrx_lib.c

   662	
   663	/**
   664	 * ice_xdp_rx_csum_lvl - Get level, at which HW has checked the checksum
   665	 * @ctx: XDP buff pointer
   666	 * @csum_status: destination address
   667	 * @csum_info: destination address
   668	 *
   669	 * Copy HW checksum level (if was checked) to the destination address.
   670	 */
   671	static int ice_xdp_rx_csum(const struct xdp_md *ctx,
   672				   enum xdp_csum_status *csum_status,
   673				   union xdp_csum_info *csum_info)
 > 674	{
   675		const struct ice_xdp_buff *xdp_ext = (void *)ctx;
   676		const union ice_32b_rx_flex_desc *eop_desc;
   677		enum ice_rx_csum_status status;
   678		u16 ptype;
   679	
   680		eop_desc = xdp_ext->pkt_ctx.eop_desc;
   681		ptype = ice_get_ptype(eop_desc);
   682	
   683		status = ice_get_rx_csum_status(eop_desc, ptype);
   684		if (status & ICE_RX_CSUM_NONE)
   685			return -ENODATA;
   686	
   687		*csum_status = XDP_CHECKSUM_VALID_LVL0 + ice_rx_csum_lvl(status);
   688		return 0;
   689	}
   690	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki