netdev - Re: [PATCH v2 07/10] net: stmmac: dwmac-loongson: Add LS7A support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACWXhKnmEgt9FFKrtcMZN75bNDuEqNoOqNtHWUP-W2s0U2JkQA@mail.gmail.com>
Date: Fri, 28 Jul 2023 10:00:34 +0800
From: Feiyang Chen <chris.chenfeiyang@...il.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: Feiyang Chen <chenfeiyang@...ngson.cn>, hkallweit1@...il.com, peppe.cavallaro@...com, 
	alexandre.torgue@...s.st.com, joabreu@...opsys.com, chenhuacai@...ngson.cn, 
	linux@...linux.org.uk, dongbiao@...ngson.cn, 
	loongson-kernel@...ts.loongnix.cn, netdev@...r.kernel.org, 
	loongarch@...ts.linux.dev
Subject: Re: [PATCH v2 07/10] net: stmmac: dwmac-loongson: Add LS7A support

On Thu, Jul 27, 2023 at 6:35 PM Andrew Lunn <andrew@...n.ch> wrote:
>
> > +static int loongson_dwmac_probe(struct pci_dev *pdev,
> > +                             const struct pci_device_id *id)
> >  {
> > +     int ret, i, bus_id, phy_mode;
> >       struct plat_stmmacenet_data *plat;
> > +     struct stmmac_pci_info *info;
> >       struct stmmac_resources res;
> >       struct device_node *np;
> > -     int ret, i, phy_mode;
> > -
> > -     np = dev_of_node(&pdev->dev);
> > -
> > -     if (!np) {
> > -             pr_info("dwmac_loongson_pci: No OF node\n");
> > -             return -ENODEV;
> > -     }
> > -
> > -     if (!of_device_is_compatible(np, "loongson, pci-gmac")) {
> > -             pr_info("dwmac_loongson_pci: Incompatible OF node\n");
> > -             return -ENODEV;
> > -     }
>
> There are a lot of changes here, and it is not easy to review.  I
> would suggest you first do a refactoring patch, moving all handling of
> DT into a helper. Since it is just moving code around, it should be
> easy to review. Then you can add support for platforms which don't
> support DT.
>

Hi, Andrew,

OK.

Thanks,
Feiyang

>         Andrew