netdev - Re: [PATCH net-next] bonding: support balance-alb with openvswitch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <872c6834-7344-5494-1094-806825fbb868@redhat.com>
Date: Sat, 29 Jul 2023 18:26:16 +0200
From: Mat Kowalski <mko@...hat.com>
To: Simon Horman <horms@...nel.org>
Cc: Jay Vosburgh <j.vosburgh@...il.com>, Andy Gospodarek
 <andy@...yhouse.net>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] bonding: support balance-alb with openvswitch


On 29/07/2023 13:12, Simon Horman wrote:
> On Fri, Jul 28, 2023 at 02:24:32PM +0200, Mat Kowalski wrote:
>> Commit d5410ac7b0ba ("net:bonding:support balance-alb interface with
>> vlan to bridge") introduced a support for balance-alb mode for
>> interfaces connected to the linux bridge by fixing missing matching of
>> MAC entry in FDB. In our testing we discovered that it still does not
>> work when the bond is connected to the OVS bridge as show in diagram
>> below:
>>
>> eth1(mac:eth1_mac)--bond0(balance-alb,mac:eth0_mac)--eth0(mac:eth0_mac)
>>                         |
>>                       bond0.150(mac:eth0_mac)
>>                                 |
>>                       ovs_bridge(ip:bridge_ip,mac:eth0_mac)
>>
>> This patch fixes it by checking not only if the device is a bridge but
>> also if it is an openvswitch.
>>
>> Signed-off-by: Mateusz Kowalski <mko@...hat.com>
> Reviewed-by: Simon Horman <horms@...nel.org>
>
Sorry for the mess, I just noticed in patchwork that it fails to apply not because of the code, but because I messed up with the line wrapping. I really hope it's the last time with such a stupid mistake; v2 is on its way