netdev - Re: [PATCH bpf-next v4 17/21] veth: Implement VLAN tag and checksum XDP hint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202307300639.I0c6g7mz-lkp@intel.com>
Date: Sun, 30 Jul 2023 06:13:05 +0800
From: kernel test robot <lkp@...el.com>
To: Larysa Zaremba <larysa.zaremba@...el.com>, bpf@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev,
	Larysa Zaremba <larysa.zaremba@...el.com>, ast@...nel.org,
	daniel@...earbox.net, andrii@...nel.org, martin.lau@...ux.dev,
	song@...nel.org, yhs@...com, john.fastabend@...il.com,
	kpsingh@...nel.org, sdf@...gle.com, haoluo@...gle.com,
	jolsa@...nel.org, David Ahern <dsahern@...il.com>,
	Jakub Kicinski <kuba@...nel.org>,
	Willem de Bruijn <willemb@...gle.com>,
	Jesper Dangaard Brouer <brouer@...hat.com>,
	Anatoly Burakov <anatoly.burakov@...el.com>,
	Alexander Lobakin <alexandr.lobakin@...el.com>,
	Magnus Karlsson <magnus.karlsson@...il.com>,
	Maryam Tahhan <mtahhan@...hat.com>, xdp-hints@...-project.net,
	netdev@...r.kernel.org,
	Alexei Starovoitov <alexei.starovoitov@...il.com>,
	Simon Horman <simon.horman@...igine.com>
Subject: Re: [PATCH bpf-next v4 17/21] veth: Implement VLAN tag and checksum
 XDP hint

Hi Larysa,

kernel test robot noticed the following build warnings:

[auto build test WARNING on bpf-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Larysa-Zaremba/ice-make-RX-HW-timestamp-reading-code-more-reusable/20230729-023952
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
patch link:    https://lore.kernel.org/r/20230728173923.1318596-18-larysa.zaremba%40intel.com
patch subject: [PATCH bpf-next v4 17/21] veth: Implement VLAN tag and checksum XDP hint
config: openrisc-randconfig-r081-20230730 (https://download.01.org/0day-ci/archive/20230730/202307300639.I0c6g7mz-lkp@intel.com/config)
compiler: or1k-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230730/202307300639.I0c6g7mz-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307300639.I0c6g7mz-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> drivers/net/veth.c:1771:37: sparse: sparse: incorrect type in assignment (different base types) @@     expected unsigned int [usertype] checksum @@     got restricted __wsum [usertype] csum @@
   drivers/net/veth.c:1771:37: sparse:     expected unsigned int [usertype] checksum
   drivers/net/veth.c:1771:37: sparse:     got restricted __wsum [usertype] csum

vim +1771 drivers/net/veth.c

  1752	
  1753	static int veth_xdp_rx_csum(const struct xdp_md *ctx,
  1754				    enum xdp_csum_status *csum_status,
  1755				    union xdp_csum_info *csum_info)
  1756	{
  1757		struct veth_xdp_buff *_ctx = (void *)ctx;
  1758		struct sk_buff *skb = _ctx->skb;
  1759	
  1760		if (!skb)
  1761			return -ENODATA;
  1762	
  1763		if (skb->ip_summed == CHECKSUM_UNNECESSARY) {
  1764			*csum_status = XDP_CHECKSUM_VALID_LVL0 + skb->csum_level;
  1765		} else if (skb->ip_summed == CHECKSUM_PARTIAL) {
  1766			*csum_status = XDP_CHECKSUM_PARTIAL;
  1767			csum_info->csum_start = skb_checksum_start_offset(skb);
  1768			csum_info->csum_offset = skb->csum_offset;
  1769		} else if (skb->ip_summed == CHECKSUM_COMPLETE) {
  1770			*csum_status = XDP_CHECKSUM_COMPLETE;
> 1771			csum_info->checksum = skb->csum;
  1772		} else {
  1773			return -ENODATA;
  1774		}
  1775	
  1776		return 0;
  1777	}
  1778	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki