netdev - Re: [PATCH net v2 1/1] net: sched: cls_u32: Fix match key mis-addressing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Sat, 29 Jul 2023 01:10:20 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Jamal Hadi Salim <jhs@...atatu.com>
Cc: davem@...emloft.net, kuba@...nel.org, edumazet@...gle.com,
 pabeni@...hat.com, jiri@...nulli.us, xiyou.wangcong@...il.com,
 netdev@...r.kernel.org, mgcho.minic@...il.com, security@...nel.org,
 torvalds@...uxfoundation.org
Subject: Re: [PATCH net v2 1/1] net: sched: cls_u32: Fix match key mis-addressing

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Wed, 26 Jul 2023 09:51:51 -0400 you wrote:
> A match entry is uniquely identified with an "address" or "path" in the
> form of: hashtable ID(12b):bucketid(8b):nodeid(12b).
> 
> When creating table match entries all of hash table id, bucket id and
> node (match entry id) are needed to be either specified by the user or
> reasonable in-kernel defaults are used. The in-kernel default for a table id is
> 0x800(omnipresent root table); for bucketid it is 0x0. Prior to this fix there
> was none for a nodeid i.e. the code assumed that the user passed the correct
> nodeid and if the user passes a nodeid of 0 (as Mingi Cho did) then that is what
> was used. But nodeid of 0 is reserved for identifying the table. This is not
> a problem until we dump. The dump code notices that the nodeid is zero and
> assumes it is referencing a table and therefore references table struct
> tc_u_hnode instead of what was created i.e match entry struct tc_u_knode.
> 
> [...]

Here is the summary with links:
  - [net,v2,1/1] net: sched: cls_u32: Fix match key mis-addressing
    https://git.kernel.org/netdev/net/c/e68409db9953

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html