| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 29 Jul 2023 17:55:57 +0800
From: kernel test robot <lkp@...el.com>
To: Amritha Nambiar <amritha.nambiar@...el.com>, netdev@...r.kernel.org,
kuba@...nel.org, davem@...emloft.net
Cc: oe-kbuild-all@...ts.linux.dev, sridhar.samudrala@...el.com,
amritha.nambiar@...el.com
Subject: Re: [net-next PATCH v1 1/9] net: Introduce new fields for napi and
queue associations
Hi Amritha,
kernel test robot noticed the following build errors:
[auto build test ERROR on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Amritha-Nambiar/net-Introduce-new-fields-for-napi-and-queue-associations/20230729-083646
base: net-next/main
patch link: https://lore.kernel.org/r/169059161688.3736.18170697577939556255.stgit%40anambiarhost.jf.intel.com
patch subject: [net-next PATCH v1 1/9] net: Introduce new fields for napi and queue associations
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20230729/202307291714.SUP7uQyV-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230729/202307291714.SUP7uQyV-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307291714.SUP7uQyV-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from drivers/infiniband/sw/rxe/rxe_comp.c:11:
>> drivers/infiniband/sw/rxe/rxe_queue.h:53:6: error: redeclaration of 'enum queue_type'
53 | enum queue_type {
| ^~~~~~~~~~
In file included from include/net/sock.h:46,
from include/linux/tcp.h:19,
from include/linux/ipv6.h:94,
from include/net/ipv6.h:12,
from include/rdma/ib_verbs.h:25,
from drivers/infiniband/sw/rxe/rxe.h:17,
from drivers/infiniband/sw/rxe/rxe_comp.c:9:
include/linux/netdevice.h:348:6: note: originally defined here
348 | enum queue_type {
| ^~~~~~~~~~
vim +53 drivers/infiniband/sw/rxe/rxe_queue.h
8700e3e7c4857d Moni Shoua 2016-06-16 9
ae6e843fe08d0e Bob Pearson 2021-09-14 10 /* Implements a simple circular buffer that is shared between user
ae6e843fe08d0e Bob Pearson 2021-09-14 11 * and the driver and can be resized. The requested element size is
ae6e843fe08d0e Bob Pearson 2021-09-14 12 * rounded up to a power of 2 and the number of elements in the buffer
ae6e843fe08d0e Bob Pearson 2021-09-14 13 * is also rounded up to a power of 2. Since the queue is empty when
ae6e843fe08d0e Bob Pearson 2021-09-14 14 * the producer and consumer indices match the maximum capacity of the
ae6e843fe08d0e Bob Pearson 2021-09-14 15 * queue is one less than the number of element slots.
5bcf5a59c41e19 Bob Pearson 2021-05-27 16 *
5bcf5a59c41e19 Bob Pearson 2021-05-27 17 * Notes:
ae6e843fe08d0e Bob Pearson 2021-09-14 18 * - The driver indices are always masked off to q->index_mask
5bcf5a59c41e19 Bob Pearson 2021-05-27 19 * before storing so do not need to be checked on reads.
ae6e843fe08d0e Bob Pearson 2021-09-14 20 * - The user whether user space or kernel is generally
ae6e843fe08d0e Bob Pearson 2021-09-14 21 * not trusted so its parameters are masked to make sure
ae6e843fe08d0e Bob Pearson 2021-09-14 22 * they do not access the queue out of bounds on reads.
ae6e843fe08d0e Bob Pearson 2021-09-14 23 * - The driver indices for queues must not be written
ae6e843fe08d0e Bob Pearson 2021-09-14 24 * by user so a local copy is used and a shared copy is
ae6e843fe08d0e Bob Pearson 2021-09-14 25 * stored when the local copy is changed.
5bcf5a59c41e19 Bob Pearson 2021-05-27 26 * - By passing the type in the parameter list separate from q
5bcf5a59c41e19 Bob Pearson 2021-05-27 27 * the compiler can eliminate the switch statement when the
ae6e843fe08d0e Bob Pearson 2021-09-14 28 * actual queue type is known when the function is called at
ae6e843fe08d0e Bob Pearson 2021-09-14 29 * compile time.
ae6e843fe08d0e Bob Pearson 2021-09-14 30 * - These queues are lock free. The user and driver must protect
ae6e843fe08d0e Bob Pearson 2021-09-14 31 * changes to their end of the queues with locks if more than one
ae6e843fe08d0e Bob Pearson 2021-09-14 32 * CPU can be accessing it at the same time.
8700e3e7c4857d Moni Shoua 2016-06-16 33 */
8700e3e7c4857d Moni Shoua 2016-06-16 34
ae6e843fe08d0e Bob Pearson 2021-09-14 35 /**
ae6e843fe08d0e Bob Pearson 2021-09-14 36 * enum queue_type - type of queue
ae6e843fe08d0e Bob Pearson 2021-09-14 37 * @QUEUE_TYPE_TO_CLIENT: Queue is written by rxe driver and
a77a52385e9a76 Bob Pearson 2023-02-14 38 * read by client which may be a user space
a77a52385e9a76 Bob Pearson 2023-02-14 39 * application or a kernel ulp.
a77a52385e9a76 Bob Pearson 2023-02-14 40 * Used by rxe internals only.
ae6e843fe08d0e Bob Pearson 2021-09-14 41 * @QUEUE_TYPE_FROM_CLIENT: Queue is written by client and
a77a52385e9a76 Bob Pearson 2023-02-14 42 * read by rxe driver.
a77a52385e9a76 Bob Pearson 2023-02-14 43 * Used by rxe internals only.
a77a52385e9a76 Bob Pearson 2023-02-14 44 * @QUEUE_TYPE_FROM_ULP: Queue is written by kernel ulp and
a77a52385e9a76 Bob Pearson 2023-02-14 45 * read by rxe driver.
a77a52385e9a76 Bob Pearson 2023-02-14 46 * Used by kernel verbs APIs only on
a77a52385e9a76 Bob Pearson 2023-02-14 47 * behalf of ulps.
a77a52385e9a76 Bob Pearson 2023-02-14 48 * @QUEUE_TYPE_TO_ULP: Queue is written by rxe driver and
a77a52385e9a76 Bob Pearson 2023-02-14 49 * read by kernel ulp.
a77a52385e9a76 Bob Pearson 2023-02-14 50 * Used by kernel verbs APIs only on
a77a52385e9a76 Bob Pearson 2023-02-14 51 * behalf of ulps.
ae6e843fe08d0e Bob Pearson 2021-09-14 52 */
59daff49f25fbb Bob Pearson 2021-05-27 @53 enum queue_type {
ae6e843fe08d0e Bob Pearson 2021-09-14 54 QUEUE_TYPE_TO_CLIENT,
ae6e843fe08d0e Bob Pearson 2021-09-14 55 QUEUE_TYPE_FROM_CLIENT,
a77a52385e9a76 Bob Pearson 2023-02-14 56 QUEUE_TYPE_FROM_ULP,
a77a52385e9a76 Bob Pearson 2023-02-14 57 QUEUE_TYPE_TO_ULP,
59daff49f25fbb Bob Pearson 2021-05-27 58 };
59daff49f25fbb Bob Pearson 2021-05-27 59
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists