netdev - Re: [PATCH v1] xfrm: add forgotten nla_policy for XFRMA_MTIMER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230730105238.GB94048@unreal>
Date: Sun, 30 Jul 2023 13:52:38 +0300
From: Leon Romanovsky <leon@...nel.org>
To: Lin Ma <linma@....edu.cn>
Cc: steffen.klassert@...unet.com, herbert@...dor.apana.org.au,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] xfrm: add forgotten nla_policy for XFRMA_MTIMER_THRESH

On Wed, Jul 26, 2023 at 09:32:43PM +0800, Lin Ma wrote:
> Hello Leon,
> 
> > 
> > This CVE is a joke, you need to be root to execute this attack.
> > 
> 
> Not really, this call routine only checks
> 
>   if (!netlink_net_capable(skb, CAP_NET_ADMIN))
>     return -EPERM;
> 
> and any users in most vendor kernel can create a network namespace to
> get such privilege and trigger this bug.

ok, fair enough.

> 
> > Anyway change is ok.
> > Reviewed-by: Leon Romanovsky <leonro@...dia.com>
> 
> Regards
> Lin