netdev - Re: [PATCH net] octeon_ep: initialize mbox mutexes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230730133600.GI94048@unreal>
Date: Sun, 30 Jul 2023 16:36:00 +0300
From: Leon Romanovsky <leon@...nel.org>
To: Michal Schmidt <mschmidt@...hat.com>
Cc: netdev@...r.kernel.org, Abhijit Ayarekar <aayarekar@...vell.com>,
	Veerasenareddy Burru <vburru@...vell.com>,
	Vimlesh Kumar <vimleshk@...vell.com>,
	Shinas Rasheed <srasheed@...vell.com>,
	Sathesh Edara <sedara@...vell.com>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH net] octeon_ep: initialize mbox mutexes

On Sat, Jul 29, 2023 at 05:15:16PM +0200, Michal Schmidt wrote:
> The two mbox-related mutexes are destroyed in octep_ctrl_mbox_uninit(),
> but the corresponding mutex_init calls were missing.
> A "DEBUG_LOCKS_WARN_ON(lock->magic != lock)" warning was emitted with
> CONFIG_DEBUG_MUTEXES on.
> 
> Initialize the two mutexes in octep_ctrl_mbox_init().
> 
> Fixes: 577f0d1b1c5f ("octeon_ep: add separate mailbox command and response queues")
> Signed-off-by: Michal Schmidt <mschmidt@...hat.com>
> ---
>  drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_mbox.c | 3 +++
>  1 file changed, 3 insertions(+)
> 

Thanks,
Reviewed-by: Leon Romanovsky <leonro@...dia.com>