netdev - Re: [PATCH iproute2-next] ip: error out if iplink does not consume all options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Sun, 30 Jul 2023 09:27:27 -0700
From: Stephen Hemminger <stephen@...workplumber.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: dsahern@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH iproute2-next] ip: error out if iplink does not consume
 all options

On Fri, 28 Jul 2023 11:33:29 -0700
Jakub Kicinski <kuba@...nel.org> wrote:

> dummy does not define .parse_opt, which make ip ignore all
> trailing arguments, for example:
> 
>  # ip link add type dummy a b c d e f name cheese
> 
> will work just fine (and won't call the device "cheese").
> Error out in this case with a clear error message:
> 
>  # ip link add type dummy a b c d e f name cheese
>  Garbage instead of arguments "a ...". Try "ip link help".
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Looks good, but then the latter check for lu->parse_opt in the if
clause is redundant.  Coverity would flag that (assuming I get
Coverity running again on iproute).