| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 31 Jul 2023 11:48:40 +0200 From: Jakub Sitnicki <jakub@...udflare.com> To: Martin KaFai Lau <martin.lau@...ux.dev> Cc: Yan Zhai <yan@...udflare.com>, bpf@...r.kernel.org, Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, Andrii Nakryiko <andrii@...nel.org>, Song Liu <song@...nel.org>, Yonghong Song <yhs@...com>, John Fastabend <john.fastabend@...il.com>, KP Singh <kpsingh@...nel.org>, Stanislav Fomichev <sdf@...gle.com>, Hao Luo <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Mykola Lysenko <mykolal@...com>, Shuah Khan <shuah@...nel.org>, linux-kernel@...r.kernel.org, netdev@...r.kernel.org, linux-kselftest@...r.kernel.org, kernel-team@...udflare.com, Jordan Griege <jgriege@...udflare.com>, Markus Elfring <Markus.Elfring@....de> Subject: Re: [PATCH v4 bpf 2/2] bpf: selftests: add lwt redirect regression test cases On Fri, Jul 28, 2023 at 03:47 PM -07, Martin KaFai Lau wrote: > On 7/25/23 6:09 PM, Yan Zhai wrote: [...] >> diff --git a/tools/testing/selftests/bpf/test_lwt_redirect.sh >> b/tools/testing/selftests/bpf/test_lwt_redirect.sh >> new file mode 100755 >> index 000000000000..1b7b78b48174 >> --- /dev/null >> +++ b/tools/testing/selftests/bpf/test_lwt_redirect.sh > > This has to be written in the test_progs infrastructure in C. Only test_progs is > run by the BPF CI. Take a look at other tests in prog_tests/. For example, > tc_redirect.c and xdp_metadata.c which are having setup in netns/link/...etc. It > currently has helpers to add tc qdisc and filter but not adding route yet which > could be a useful addition. Can we help make the BPF CI better so that it also runs other tests in addition test_progs? We have bpf selftests written in shell and even Python. These are sometimes the right tools for the job and make adding tests easier, IMHO. Network setup from C is verbose and tedious. Not to mention, hard to read through. # ./run_kselftest.sh --list bpf:test_verifier bpf:test_tag bpf:test_maps bpf:test_lru_map bpf:test_lpm_map bpf:test_progs bpf:test_dev_cgroup bpf:test_sock bpf:test_sockmap bpf:get_cgroup_id_user bpf:test_cgroup_storage bpf:test_tcpnotify_user bpf:test_sysctl bpf:test_progs-no_alu32 bpf:test_kmod.sh bpf:test_xdp_redirect.sh bpf:test_xdp_redirect_multi.sh bpf:test_xdp_meta.sh bpf:test_xdp_veth.sh bpf:test_offload.py bpf:test_sock_addr.sh bpf:test_tunnel.sh bpf:test_lwt_seg6local.sh bpf:test_lirc_mode2.sh bpf:test_skb_cgroup_id.sh bpf:test_flow_dissector.sh bpf:test_xdp_vlan_mode_generic.sh bpf:test_xdp_vlan_mode_native.sh bpf:test_lwt_ip_encap.sh bpf:test_tcp_check_syncookie.sh bpf:test_tc_tunnel.sh bpf:test_tc_edt.sh bpf:test_xdping.sh bpf:test_bpftool_build.sh bpf:test_bpftool.sh bpf:test_bpftool_metadata.sh bpf:test_doc_build.sh bpf:test_xsk.sh bpf:test_xdp_features.sh
Powered by blists - more mailing lists