netdev - Re: [PATCH net-next] vsock: Remove unused function declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 31 Jul 2023 11:55:07 +0200
From: Stefano Garzarella <sgarzare@...hat.com>
To: Yue Haibing <yuehaibing@...wei.com>
Cc: bryantan@...are.com, vdasa@...are.com, pv-drivers@...are.com, 
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, 
	linux-kernel@...r.kernel.org, virtualization@...ts.linux-foundation.org, 
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] vsock: Remove unused function declarations

On Sat, Jul 29, 2023 at 08:20:36PM +0800, Yue Haibing wrote:
>These are never implemented since introduction in
>commit d021c344051a ("VSOCK: Introduce VM Sockets")
>
>Signed-off-by: Yue Haibing <yuehaibing@...wei.com>
>---
> net/vmw_vsock/vmci_transport.h | 3 ---
> 1 file changed, 3 deletions(-)

Good catch ;-)

I'd used "vsock/vmci:" as a prefix in the title.

With or without:

Reviewed-by: Stefano Garzarella <sgarzare@...hat.com>

>
>diff --git a/net/vmw_vsock/vmci_transport.h b/net/vmw_vsock/vmci_transport.h
>index b7b072194282..dbda3ababa14 100644
>--- a/net/vmw_vsock/vmci_transport.h
>+++ b/net/vmw_vsock/vmci_transport.h
>@@ -116,9 +116,6 @@ struct vmci_transport {
> 	spinlock_t lock; /* protects sk. */
> };
>
>-int vmci_transport_register(void);
>-void vmci_transport_unregister(void);
>-
> int vmci_transport_send_wrote_bh(struct sockaddr_vm *dst,
> 				 struct sockaddr_vm *src);
> int vmci_transport_send_read_bh(struct sockaddr_vm *dst,
>-- 
>2.34.1
>
>