netdev - RE: [PATCH net] net: ll_temac: fix error checking of irq_of_parse_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <BYAPR12MB4773D13A8899C2F47CA66C049E05A@BYAPR12MB4773.namprd12.prod.outlook.com>
Date: Mon, 31 Jul 2023 10:57:31 +0000
From: "Katakam, Harini" <harini.katakam@....com>
To: Dan Carpenter <dan.carpenter@...aro.org>, Esben Haabendal
	<esben@...nix.com>
CC: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
	<edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, "Simek, Michal" <michal.simek@....com>, Haoyue Xu
	<xuhaoyue1@...ilicon.com>, huangjunxian <huangjunxian6@...ilicon.com>, Yang
 Yingliang <yangyingliang@...wei.com>, Rob Herring <robh@...nel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: RE: [PATCH net] net: ll_temac: fix error checking of
 irq_of_parse_and_map()



> -----Original Message-----
> From: Dan Carpenter <dan.carpenter@...aro.org>
> Sent: Monday, July 31, 2023 1:13 PM
> To: Esben Haabendal <esben@...nix.com>
> Cc: David S. Miller <davem@...emloft.net>; Eric Dumazet
> <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni
> <pabeni@...hat.com>; Simek, Michal <michal.simek@....com>; Katakam,
> Harini <harini.katakam@....com>; Haoyue Xu <xuhaoyue1@...ilicon.com>;
> huangjunxian <huangjunxian6@...ilicon.com>; Yang Yingliang
> <yangyingliang@...wei.com>; Rob Herring <robh@...nel.org>;
> netdev@...r.kernel.org; kernel-janitors@...r.kernel.org
> Subject: [PATCH net] net: ll_temac: fix error checking of
> irq_of_parse_and_map()
> 
> Most kernel functions return negative error codes but some irq functions
> return zero on error.  In this code irq_of_parse_and_map(), returns zero
> and platform_get_irq() returns negative error codes.  We need to handle
> both cases appropriately.
> 
> Fixes: 8425c41d1ef7 ("net: ll_temac: Extend support to non-device-tree
> platforms")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Thanks,
Reviewed-by: Harini Katakam <harini.katakam@....com>

Regards,
Harini