netdev - Re: [PATCH net-next] net: lan743x: skip timestamping for non-PTP packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZMe8To+Rw0/pcjLv@hoboy.vegasvil.org>
Date: Mon, 31 Jul 2023 06:51:10 -0700
From: Richard Cochran <richardcochran@...il.com>
To: Vishvambar Panth S <vishvambarpanth.s@...rochip.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	bryan.whitehead@...rochip.com, UNGLinuxDriver@...rochip.com,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com
Subject: Re: [PATCH net-next] net: lan743x: skip timestamping for non-PTP
 packets

On Mon, Jul 31, 2023 at 06:24:18PM +0530, Vishvambar Panth S wrote:
> Currently all the RX packets are timestamped and the timestamp is appended
> to the RX packet for processing, this reduces RX throughput. This can be
> optimized by timestamping packets only when the PTP messages are received.

No, you should not do this unconditionally.

Instead, you need to dial the correct setting based on the
hwtstamp_config in lan743x_ptp_ioctl().

Thanks,
Richard