netdev - Re: [PATCH 3/5] rtc: ds1685: use EXPORT_SYMBOL_GPL for ds1685_rtc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c545bc4f-6fe9-eca4-535e-2380fd639ea3@gentoo.org>
Date: Mon, 31 Jul 2023 11:08:41 -0400
From: Joshua Kinard <kumba@...too.org>
To: Christoph Hellwig <hch@....de>, Luis Chamberlain <mcgrof@...nel.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Daniel Mack <daniel@...que.org>, Haojian Zhuang <haojian.zhuang@...il.com>,
 Robert Jarzmik <robert.jarzmik@...e.fr>, Ulf Hansson
 <ulf.hansson@...aro.org>, Yangbo Lu <yangbo.lu@....com>
Cc: Daniel Vetter <daniel.vetter@...ll.ch>,
 linux-arm-kernel@...ts.infradead.org,
 open list <linux-kernel@...r.kernel.org>, linux-mmc@...r.kernel.org,
 netdev@...r.kernel.org, linux-rtc@...r.kernel.org,
 linux-modules@...r.kernel.org
Subject: Re: [PATCH 3/5] rtc: ds1685: use EXPORT_SYMBOL_GPL for
 ds1685_rtc_poweroff

On 7/31/2023 04:38, Christoph Hellwig wrote:
> ds1685_rtc_poweroff is only used externally via symbol_get, which was
> only ever intended for very internal symbols like this one.  Use
> EXPORT_SYMBOL_GPL for it so that symbol_get can enforce only being used
> on EXPORT_SYMBOL_GPL symbols.
> 
> Signed-off-by: Christoph Hellwig <hch@....de>
> ---
>   drivers/rtc/rtc-ds1685.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/rtc/rtc-ds1685.c b/drivers/rtc/rtc-ds1685.c
> index 0f707be0eb87fa..04dbf35cf3b706 100644
> --- a/drivers/rtc/rtc-ds1685.c
> +++ b/drivers/rtc/rtc-ds1685.c
> @@ -1432,7 +1432,7 @@ ds1685_rtc_poweroff(struct platform_device *pdev)
>   		unreachable();
>   	}
>   }
> -EXPORT_SYMBOL(ds1685_rtc_poweroff);
> +EXPORT_SYMBOL_GPL(ds1685_rtc_poweroff);
>   /* ----------------------------------------------------------------------- */
>   
>   

Acked-by: Joshua Kinard <kumba@...too.org>