netdev - Re: [PATCH v2 06/10] net: stmmac: Add Loongson HWIF entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZMfQUI1BOd1RWM4u@shell.armlinux.org.uk>
Date: Mon, 31 Jul 2023 16:16:32 +0100
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Feiyang Chen <chris.chenfeiyang@...il.com>
Cc: Feiyang Chen <chenfeiyang@...ngson.cn>, andrew@...n.ch,
	hkallweit1@...il.com, peppe.cavallaro@...com,
	alexandre.torgue@...s.st.com, joabreu@...opsys.com,
	chenhuacai@...ngson.cn, dongbiao@...ngson.cn,
	loongson-kernel@...ts.loongnix.cn, netdev@...r.kernel.org,
	loongarch@...ts.linux.dev
Subject: Re: [PATCH v2 06/10] net: stmmac: Add Loongson HWIF entry

On Mon, Jul 31, 2023 at 05:46:57PM +0800, Feiyang Chen wrote:
> On Fri, Jul 28, 2023 at 5:24 PM Russell King (Oracle)
> <linux@...linux.org.uk> wrote:
> >
> > On Thu, Jul 27, 2023 at 03:18:06PM +0800, Feiyang Chen wrote:
> > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> > > index e8619853b6d6..829de274e75d 100644
> > > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> > > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> > > @@ -3505,17 +3505,21 @@ static int stmmac_request_irq_multi_msi(struct net_device *dev)
> > >  {
> > >       struct stmmac_priv *priv = netdev_priv(dev);
> > >       enum request_irq_err irq_err;
> > > +     unsigned long flags = 0;
> > >       cpumask_t cpu_mask;
> > >       int irq_idx = 0;
> > >       char *int_name;
> > >       int ret;
> > >       int i;
> > >
> > > +     if (priv->plat->has_lgmac)
> > > +             flags |= IRQF_TRIGGER_RISING;
> >
> > Can this be described in firmware?
> >
> 
> Hi, Russell,
> 
> I'm not sure, could you explain what you mean?

Modern systems describe the IRQ triggering in firmware for the OS
such as DT. Does your implementation have any firmware that can
do this kind of description for you (e.g. DT, ACPI?)

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!