netdev - Error 'netif_napi_add_weight() called with weight 256'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date: Mon, 31 Jul 2023 11:02:40 -0500
From: "Limonciello, Mario" <mario.limonciello@....com>
To: kuba@...nel.org, hayeswang@...ltek.com, edumazet@...gle.com
Cc: LKML <linux-kernel@...r.kernel.org>, netdev@...r.kernel.org,
 davem@...emloft.net, linux-usb@...r.kernel.org, pabeni@...hat.com,
 Paul Menzel <pmenzel@...gen.mpg.de>
Subject: Error 'netif_napi_add_weight() called with weight 256'

Hi,

I noticed today with 6.5-rc4 and also on 6.1.42 that I'm getting an 
error from an r8152 based dongle (Framework ethernet expansion card).

netif_napi_add_weight() called with weight 256

It seems that this message is likely introduced by
8ded532cd1cbe ("r8152: switch to netif_napi_add_weight()")

which if the card has support_2500full set will program the value to 256:

	netif_napi_add_weight(netdev, &tp->napi, r8152_poll,
			      tp->support_2500full ? 256 : 64);

It's err level from
82dc3c63c692b ("net: introduce NAPI_POLL_WEIGHT")

Why is this considered an error but the driver uses the bigger value?
Should it be downgraded to a warning?

Thanks,