netdev - Re: [PATCH] net/macmace: Replace zero-length array with DECLARE_FLEX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230731073801.GA87829@unreal>
Date: Mon, 31 Jul 2023 10:38:01 +0300
From: Leon Romanovsky <leon@...nel.org>
To: Atul Raut <rauji.raut@...il.com>
Cc: avem@...emloft.net, netdev@...r.kernel.org, kuba@...nel.org,
	pabeni@...hat.com, rafal@...ecki.pl,
	linux-kernel-mentees@...ts.linuxfoundation.org
Subject: Re: [PATCH] net/macmace: Replace zero-length array with
 DECLARE_FLEX_ARRAY() helper

On Sun, Jul 30, 2023 at 04:14:42PM -0700, Atul Raut wrote:
> Since zero-length arrays are deprecated, we are replacing
> them with C99 flexible-array members. As a result, instead
> of declaring a zero-length array, use the new
> DECLARE_FLEX_ARRAY() helper macro.
> 
> This fixes warnings such as:
> ./drivers/net/ethernet/apple/macmace.c:80:4-8: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
> 
> Signed-off-by: Atul Raut <rauji.raut@...il.com>
> ---
>  drivers/net/ethernet/apple/macmace.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/apple/macmace.c b/drivers/net/ethernet/apple/macmace.c
> index 8fcaf1639920..8775c3234e91 100644
> --- a/drivers/net/ethernet/apple/macmace.c
> +++ b/drivers/net/ethernet/apple/macmace.c
> @@ -77,7 +77,7 @@ struct mace_frame {
>  	u8	pad4;
>  	u32	pad5;
>  	u32	pad6;
> -	u8	data[1];
> +	DECLARE_FLEX_ARRAY(u8, data);

But data[1] is not zero-length array.

>  	/* And frame continues.. */
>  };
>  
> -- 
> 2.34.1
> 
>