netdev - Re: [PATCH 4.19] net/sched: cls_fw: Fix improper refcount update leads to use-after-free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 1 Aug 2023 10:21:13 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: SeongJae Park <sj@...nel.org>
Cc: stable@...r.kernel.org, M A Ramdhan <ramdhan@...rlabs.sg>,
	sashal@...nel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, hailmo@...zon.com,
	Jamal Hadi Salim <jhs@...atatu.com>,
	Pedro Tammela <pctammela@...atatu.com>,
	Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH 4.19] net/sched: cls_fw: Fix improper refcount update
 leads to use-after-free

On Thu, Jul 27, 2023 at 05:46:28PM +0000, SeongJae Park wrote:
> From: M A Ramdhan <ramdhan@...rlabs.sg>
> 
> [ Upstream commit 0323bce598eea038714f941ce2b22541c46d488f ]
> 
> In the event of a failure in tcf_change_indev(), fw_set_parms() will
> immediately return an error after incrementing or decrementing
> reference counter in tcf_bind_filter().  If attacker can control
> reference counter to zero and make reference freed, leading to
> use after free.
> 
> In order to prevent this, move the point of possible failure above the
> point where the TC_FW_CLASSID is handled.
> 
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Reported-by: M A Ramdhan <ramdhan@...rlabs.sg>
> Signed-off-by: M A Ramdhan <ramdhan@...rlabs.sg>
> Acked-by: Jamal Hadi Salim <jhs@...atatu.com>
> Reviewed-by: Pedro Tammela <pctammela@...atatu.com>
> Message-ID: <20230705161530.52003-1-ramdhan@...rlabs.sg>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> Signed-off-by: SeongJae Park <sj@...nel.org>
> ---
>  net/sched/cls_fw.c | 10 +++++-----

Both now queued up, thanks.

greg k-h