netdev - Re: [PATCH net-next] net: Remove duplicated include in mac.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 1 Aug 2023 12:06:07 +0200
From: Simon Horman <horms@...nel.org>
To: Yang Li <yang.lee@...ux.alibaba.com>
Cc: madalin.bucur@....com, davem@...emloft.net, kuba@...nel.org,
	edumazet@...gle.com, sean.anderson@...o.com, pabeni@...hat.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH net-next] net: Remove duplicated include in mac.c

On Tue, Aug 01, 2023 at 08:50:41AM +0800, Yang Li wrote:
> ./drivers/net/ethernet/freescale/fman/mac.c: linux/of_platform.h is included more than once.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6039
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>

Looking at git history, I think that a slightly better prefix would be
'net: fman: '.

	Subject: [PATCH net-next] net: fman: ...

But other than that, this looks good to me.

Reviewed-by: Simon Horman <horms@...nel.org>