netdev - Re: [net-next PATCH v1 3/9] netdev-genl: spec: Extend netdev netlink spec in YAML for NAPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230731171308.230bf737@kernel.org>
Date: Mon, 31 Jul 2023 17:13:08 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: "Nambiar, Amritha" <amritha.nambiar@...el.com>
Cc: <netdev@...r.kernel.org>, <davem@...emloft.net>,
 <sridhar.samudrala@...el.com>
Subject: Re: [net-next PATCH v1 3/9] netdev-genl: spec: Extend netdev
 netlink spec in YAML for NAPI

On Mon, 31 Jul 2023 16:12:23 -0700 Nambiar, Amritha wrote:
> > Every NAPI instance should be dumped as a separate object. We can
> > implemented filtered dump to get NAPIs of a single netdev.
> 
> Today, the 'do napi-get <ifindex>' will show all the NAPIs for a single 
> netdev:
> Example: --do napi-get --json='{"ifindex": 6}'
> 
> and the 'dump napi-get' will dump all the NAPIs for all the netdevs.
> Example: netdev.yaml  --dump napi-get
> 
> Are you suggesting that we also dump each NAPI instance individually,
> 'do napi-get <ifindex> <NAPI_ID>'
> 
> Example:
> netdev.yaml  --do napi-get --json='{"ifindex": 6, "napi-id": 390}'
> 
> [{'ifindex': 6},
>   {'napi-info': [{'irq': 296,
>                   'napi-id': 390,
>                   'pid': 3475,
>                   'rx-queues': [5],
>                   'tx-queues': [5]}]}]

Dumps can be filtered, I'm saying:

$ netdev.yaml --dump napi-get --json='{"ifindex": 6}'
                ^^^^

[{'napi-id': 390, 'ifindex': 6, 'irq': 296, ...},
 {'napi-id': 391, 'ifindex': 6, 'irq': 297, ...}]