netdev - Re: [Intel-wired-lan] [PATCH iwl-net] ice: Block switchdev mode when ADQ is acvite and vice versa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ddbc01d5-34c9-eea6-2c8f-6c8758a92792@intel.com>
Date: Tue, 1 Aug 2023 14:06:25 +0200
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: Marcin Szycik <marcin.szycik@...ux.intel.com>,
	<intel-wired-lan@...ts.osuosl.org>
CC: <netdev@...r.kernel.org>
Subject: Re: [Intel-wired-lan] [PATCH iwl-net] ice: Block switchdev mode when
 ADQ is acvite and vice versa

On 8/1/23 13:52, Marcin Szycik wrote:
> ADQ and switchdev are not supported simultaneously. Enabling both at the
> same time can result in nullptr dereference.
> 
> To prevent this, check if ADQ is active when changing devlink mode to
> switchdev mode, and check if switchdev is active when enabling ADQ.
> 
> Fixes: fbc7b27af0f9 ("ice: enable ndo_setup_tc support for mqprio_qdisc")
> Signed-off-by: Marcin Szycik <marcin.szycik@...ux.intel.com>
> ---
>   drivers/net/ethernet/intel/ice/ice_eswitch.c | 5 +++++
>   drivers/net/ethernet/intel/ice/ice_main.c    | 6 ++++++
>   2 files changed, 11 insertions(+)
> 

Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>