netdev - Re: [PATCH] netfilter: bpf: Only define get_proto_defrag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAADnVQJXC0votVOBOK7KynVEt9Z5JzMpD22GKS0RJkh0vdrK4A@mail.gmail.com>
Date: Mon, 31 Jul 2023 17:53:29 -0700
From: Alexei Starovoitov <alexei.starovoitov@...il.com>
To: Daniel Xu <dxu@...uu.xyz>
Cc: Jozsef Kadlecsik <kadlec@...filter.org>, "David S. Miller" <davem@...emloft.net>, 
	Paolo Abeni <pabeni@...hat.com>, Alexei Starovoitov <ast@...nel.org>, Eric Dumazet <edumazet@...gle.com>, 
	Pablo Neira Ayuso <pablo@...filter.org>, Jakub Kicinski <kuba@...nel.org>, Florian Westphal <fw@...len.de>, 
	netfilter-devel <netfilter-devel@...r.kernel.org>, coreteam@...filter.org, 
	Network Development <netdev@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>, 
	bpf <bpf@...r.kernel.org>, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] netfilter: bpf: Only define get_proto_defrag_hook() if necessary

On Mon, Jul 31, 2023 at 2:55 PM Daniel Xu <dxu@...uu.xyz> wrote:
>
> Before, we were getting this warning:
>
>   net/netfilter/nf_bpf_link.c:32:1: warning: 'get_proto_defrag_hook' defined but not used [-Wunused-function]
>
> Guard the definition with CONFIG_NF_DEFRAG_IPV[4|6].
>
> Fixes: 91721c2d02d3 ("netfilter: bpf: Support BPF_F_NETFILTER_IP_DEFRAG in netfilter link")

since that commit is in bpf-next only
please use [PATCH bpf-next] in the future to make sure BPF CI can test it.

I've applied it after manual testing, but very much prefer
the automation to do it for me.