netdev - RE: [PATCH v2 net-next 0/4] net: extend alloc_skb_with

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <64c9737d36571_1d4d6f294b@willemb.c.googlers.com.notmuch>
Date: Tue, 01 Aug 2023 17:05:01 -0400
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Eric Dumazet <edumazet@...gle.com>, 
 "David S . Miller" <davem@...emloft.net>, 
 Jakub Kicinski <kuba@...nel.org>, 
 Paolo Abeni <pabeni@...hat.com>
Cc: Willem de Bruijn <willemb@...gle.com>, 
 Tahsin Erdogan <trdgn@...zon.com>, 
 netdev@...r.kernel.org, 
 eric.dumazet@...il.com, 
 Eric Dumazet <edumazet@...gle.com>
Subject: RE: [PATCH v2 net-next 0/4] net: extend alloc_skb_with_frags() max
 size

Eric Dumazet wrote:
> alloc_skb_with_frags(), while being able to use high order allocations,
> limits the payload size to PAGE_SIZE * MAX_SKB_FRAGS
> 
> Reviewing Tahsin Erdogan patch [1], it was clear to me we need
> to remove this limitation.
> 
> [1] https://lore.kernel.org/netdev/20230731230736.109216-1-trdgn@amazon.com/
> 
> v2: Addressed Willem feedback on 1st patch.
> 
> Eric Dumazet (4):
>   net: allow alloc_skb_with_frags() to allocate bigger packets
>   net: tun: change tun_alloc_skb() to allow bigger paged allocations
>   net/packet: change packet_alloc_skb() to allow bigger paged
>     allocations
>   net: tap: change tap_alloc_skb() to allow bigger paged allocations
> 
>  drivers/net/tap.c      |  4 ++-
>  drivers/net/tun.c      |  4 ++-
>  net/core/skbuff.c      | 56 +++++++++++++++++++-----------------------
>  net/packet/af_packet.c |  4 ++-
>  4 files changed, 34 insertions(+), 34 deletions(-)

For the series:

Reviewed-by: Willem de Bruijn <willemb@...gle.com>

Thanks Eric