netdev - Re: [PATCH] net/macmace: Replace zero-length array with DECLARE_FLEX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230801145115.153f3629@kernel.org>
Date: Tue, 1 Aug 2023 14:51:15 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Atul Raut <rauji.raut@...il.com>
Cc: Larysa Zaremba <larysa.zaremba@...el.com>, <avem@...emloft.net>,
 <netdev@...r.kernel.org>, <pabeni@...hat.com>, <rafal@...ecki.pl>,
 <linux-kernel-mentees@...ts.linuxfoundation.org>
Subject: Re: [PATCH] net/macmace: Replace zero-length array with
 DECLARE_FLEX_ARRAY() helper

On Tue, 1 Aug 2023 16:09:37 +0200 Larysa Zaremba wrote:
> > > -	u8	data[1];
> > > +	DECLARE_FLEX_ARRAY(u8, data);  
> > 
> > But data[1] is not zero-length array.
> 
> So, please, if you are certain that data should be a flexible array,
> send v2 without calling data a zero-length array. Also, with such change, I 
> think driver code could be improved in many places in the same patchset.

Atul, you should respond to reviewers promptly. These are legit
questions.
On closer inspection the patch looks fine so to avoid clogging up 
the review queue and wasting more time on it I'm just going to apply it.