netdev - Re: [PATCH iproute2-next] tc: Classifier support for SPI field

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5222d4e2-dd19-fc77-23f0-ce96684e9470@gmail.com>
Date: Mon, 31 Jul 2023 20:35:39 -0600
From: David Ahern <dsahern@...il.com>
To: Ratheesh Kannoth <rkannoth@...vell.com>,
 "stephen@...workplumber.org" <stephen@...workplumber.org>
Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 "davem@...emloft.net" <davem@...emloft.net>,
 "kuba@...nel.org" <kuba@...nel.org>, Leon Romanovsky <leon@...nel.org>,
 "edumazet@...gle.com" <edumazet@...gle.com>,
 "pabeni@...hat.com" <pabeni@...hat.com>
Subject: Re: [PATCH iproute2-next] tc: Classifier support for SPI field

On 7/31/23 7:53 PM, Ratheesh Kannoth wrote:
>> From: Ratheesh Kannoth <rkannoth@...vell.com>
>> Sent: Tuesday, July 25, 2023 9:20 AM
>> To: dsahern@...il.com; stephen@...workplumber.org
>> Cc: netdev@...r.kernel.org; Ratheesh Kannoth <rkannoth@...vell.com>
>> Subject: [PATCH iproute2-next] tc: Classifier support for SPI field
>>
>> tc flower support for SPI field in ESP and AH packets.
>>
>> Signed-off-by: Ratheesh Kannoth <rkannoth@...vell.com>
>> ---
>>  include/uapi/linux/pkt_cls.h |  5 +++-
>>  tc/f_flower.c                | 55 ++++++++++++++++++++++++++++++++++--
>>  2 files changed, 57 insertions(+), 3 deletions(-)
>>
>> diff --git a/include/uapi/linux/pkt_cls.h b/include/uapi/linux/pkt_cls.h index
>> 7865f5a9..fce639a6 100644
>> --- a/include/uapi/linux/pkt_cls.h
>> +++ b/include/uapi/linux/pkt_cls.h
>> @@ -594,6 +594,9 @@ enum {
>>
>>  	TCA_FLOWER_KEY_L2TPV3_SID,	/* be32 */
>>
>> +	TCA_FLOWER_KEY_SPI,		/* be32 */
>> +	TCA_FLOWER_KEY_SPI_MASK,	/* be32 */
>> +
>>  	TCA_FLOWER_L2_MISS,		/* u8 */
>>
>>  	TCA_FLOWER_KEY_CFM,		/* nested */
> 
> As per https://lore.kernel.org/netdev/20230731120254.GB87829@unreal/T/#u  ,  I will move these fields to  end in the enum.  
> Could you please discard https://patchwork.kernel.org/project/netdevbpf/patch/20230725035016.505386-1-rkannoth@marvell.com/  this  from netdev patchwork ?

you do not need to include uapi changes in an iproute2 patch; headers
are sync'ed from the kernel.