netdev - Re: [PATCH net-next v2] netconsole: Enable compile time configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230731195258.16b3a53d@kernel.org>
Date: Mon, 31 Jul 2023 19:52:58 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Breno Leitao <leitao@...ian.org>
Cc: rdunlap@...radead.org, benjamin.poirier@...il.com, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, leit@...a.com, netdev@...r.kernel.org (open
 list:NETWORKING DRIVERS), linux-kernel@...r.kernel.org (open list)
Subject: Re: [PATCH net-next v2] netconsole: Enable compile time
 configuration

On Mon, 31 Jul 2023 01:35:41 -0700 Breno Leitao wrote:
> +config NETCONSOLE_EXTENDED_LOG
> +	bool "Set kernel extended message as default"
> +	depends on NETCONSOLE
> +	default n
> +	help
> +	  Set extended log support for netconsole message. If this option is
> +	  set, log messages are transmitted with extended metadata header in a
> +	  format similar to /dev/kmsg.  See
> +	  <file:Documentation/networking/netconsole.rst> for details.
> +
> +config NETCONSOLE_PREPEND_RELEASE
> +	bool "Prepend kernel release version in the message"

... by default

> +	depends on NETCONSOLE_EXTENDED_LOG
> +	default n
> +	help
> +	  Set kernel release to be prepended to each netconsole message by
> +	  default. If this option is set, the kernel release is prepended into
> +	  the first field of every netconsole message, so, the netconsole
> +	  server/peer can easily identify what kernel release is logging each
> +	  message.  See <file:Documentation/networking/netconsole.rst> for
> +	  details.

I had to look at the code to see what this does, exactly.

I think you either need to make similar changes to
make_netconsole_target() so that instances created via sysfs
have the same default.

Or rewrite the help message to talk about forcing kernel
command line arguments, rather than setting defaults.
-- 
pw-bot: cr