netdev - Re: [PATCH net v2 0/3] net/sched Bind logic fixes for cls_fw, cls_u32 and cls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 01 Aug 2023 03:20:22 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Jamal Hadi Salim <jhs@...atatu.com>
Cc: davem@...emloft.net, kuba@...nel.org, edumazet@...gle.com,
 pabeni@...hat.com, jiri@...nulli.us, xiyou.wangcong@...il.com,
 netdev@...r.kernel.org, sec@...is.email, ramdhan@...rlabs.sg,
 billy@...rlabs.sg
Subject: Re: [PATCH net v2 0/3] net/sched Bind logic fixes for cls_fw,
 cls_u32 and cls_route

Hello:

This series was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Sat, 29 Jul 2023 08:31:59 -0400 you wrote:
> From: valis <sec@...is.email>
> 
> Three classifiers (cls_fw, cls_u32 and cls_route) always copy
> tcf_result struct into the new instance of the filter on update.
> 
> This causes a problem when updating a filter bound to a class,
> as tcf_unbind_filter() is always called on the old instance in the
> success path, decreasing filter_cnt of the still referenced class
> and allowing it to be deleted, leading to a use-after-free.
> 
> [...]

Here is the summary with links:
  - [net,v2,1/3] net/sched: cls_u32: No longer copy tcf_result on update to avoid use-after-free
    https://git.kernel.org/netdev/net/c/3044b16e7c6f
  - [net,v2,2/3] net/sched: cls_fw: No longer copy tcf_result on update to avoid use-after-free
    https://git.kernel.org/netdev/net/c/76e42ae83199
  - [net,v2,3/3] net/sched: cls_route: No longer copy tcf_result on update to avoid use-after-free
    https://git.kernel.org/netdev/net/c/b80b829e9e2c

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html