netdev - RE: [PATCH bpf-next 1/3] eth: add missing xdp.h includes in drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID:
 <AM5PR04MB3139645760B883F05BDB53CD880BA@AM5PR04MB3139.eurprd04.prod.outlook.com>
Date: Wed, 2 Aug 2023 02:26:02 +0000
From: Wei Fang <wei.fang@....com>
To: Jakub Kicinski <kuba@...nel.org>, "ast@...nel.org" <ast@...nel.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "bpf@...r.kernel.org"
	<bpf@...r.kernel.org>, "hawk@...nel.org" <hawk@...nel.org>,
	"amritha.nambiar@...el.com" <amritha.nambiar@...el.com>,
	"aleksander.lobakin@...el.com" <aleksander.lobakin@...el.com>,
	"j.vosburgh@...il.com" <j.vosburgh@...il.com>, "andy@...yhouse.net"
	<andy@...yhouse.net>, "shayagr@...zon.com" <shayagr@...zon.com>,
	"akiyano@...zon.com" <akiyano@...zon.com>, Ioana Ciornei
	<ioana.ciornei@....com>, Claudiu Manoil <claudiu.manoil@....com>, Vladimir
 Oltean <vladimir.oltean@....com>, Shenwei Wang <shenwei.wang@....com>, Clark
 Wang <xiaoning.wang@....com>, dl-linux-imx <linux-imx@....com>,
	"dmichail@...gible.com" <dmichail@...gible.com>, "jeroendb@...gle.com"
	<jeroendb@...gle.com>, "pkaligineedi@...gle.com" <pkaligineedi@...gle.com>,
	"shailend@...gle.com" <shailend@...gle.com>, "jesse.brandeburg@...el.com"
	<jesse.brandeburg@...el.com>, "anthony.l.nguyen@...el.com"
	<anthony.l.nguyen@...el.com>, "horatiu.vultur@...rochip.com"
	<horatiu.vultur@...rochip.com>, "UNGLinuxDriver@...rochip.com"
	<UNGLinuxDriver@...rochip.com>, "kys@...rosoft.com" <kys@...rosoft.com>,
	"haiyangz@...rosoft.com" <haiyangz@...rosoft.com>, "wei.liu@...nel.org"
	<wei.liu@...nel.org>, "decui@...rosoft.com" <decui@...rosoft.com>,
	"peppe.cavallaro@...com" <peppe.cavallaro@...com>,
	"alexandre.torgue@...s.st.com" <alexandre.torgue@...s.st.com>,
	"joabreu@...opsys.com" <joabreu@...opsys.com>, "mcoquelin.stm32@...il.com"
	<mcoquelin.stm32@...il.com>, "grygorii.strashko@...com"
	<grygorii.strashko@...com>, "longli@...rosoft.com" <longli@...rosoft.com>,
	"sharmaajay@...rosoft.com" <sharmaajay@...rosoft.com>, "daniel@...earbox.net"
	<daniel@...earbox.net>, "john.fastabend@...il.com"
	<john.fastabend@...il.com>, "gerhard@...leder-embedded.com"
	<gerhard@...leder-embedded.com>, "simon.horman@...igine.com"
	<simon.horman@...igine.com>, "leon@...nel.org" <leon@...nel.org>,
	"linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>
Subject: RE: [PATCH bpf-next 1/3] eth: add missing xdp.h includes in drivers

> Handful of drivers currently expect to get xdp.h by virtue of including
> netdevice.h. This will soon no longer be the case so add explicit includes.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: j.vosburgh@...il.com
> CC: andy@...yhouse.net
> CC: shayagr@...zon.com
> CC: akiyano@...zon.com
> CC: ioana.ciornei@....com
> CC: claudiu.manoil@....com
> CC: vladimir.oltean@....com
> CC: wei.fang@....com
> CC: shenwei.wang@....com
> CC: xiaoning.wang@....com
> CC: linux-imx@....com
> CC: dmichail@...gible.com
> CC: jeroendb@...gle.com
> CC: pkaligineedi@...gle.com
> CC: shailend@...gle.com
> CC: jesse.brandeburg@...el.com
> CC: anthony.l.nguyen@...el.com
> CC: horatiu.vultur@...rochip.com
> CC: UNGLinuxDriver@...rochip.com
> CC: kys@...rosoft.com
> CC: haiyangz@...rosoft.com
> CC: wei.liu@...nel.org
> CC: decui@...rosoft.com
> CC: peppe.cavallaro@...com
> CC: alexandre.torgue@...s.st.com
> CC: joabreu@...opsys.com
> CC: mcoquelin.stm32@...il.com
> CC: grygorii.strashko@...com
> CC: longli@...rosoft.com
> CC: sharmaajay@...rosoft.com
> CC: daniel@...earbox.net
> CC: hawk@...nel.org
> CC: john.fastabend@...il.com
> CC: gerhard@...leder-embedded.com
> CC: simon.horman@...igine.com
> CC: leon@...nel.org
> CC: linux-hyperv@...r.kernel.org
> CC: bpf@...r.kernel.org
> ---
>  drivers/net/bonding/bond_main.c                       | 1 +
>  drivers/net/ethernet/amazon/ena/ena_netdev.h          | 1 +
>  drivers/net/ethernet/engleder/tsnep.h                 | 1 +
>  drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.h      | 1 +
>  drivers/net/ethernet/freescale/enetc/enetc.h          | 1 +
>  drivers/net/ethernet/freescale/fec.h                  | 1 +
>  drivers/net/ethernet/fungible/funeth/funeth_txrx.h    | 1 +
>  drivers/net/ethernet/google/gve/gve.h                 | 1 +
>  drivers/net/ethernet/intel/igc/igc.h                  | 1 +
>  drivers/net/ethernet/microchip/lan966x/lan966x_main.h | 1 +
>  drivers/net/ethernet/microsoft/mana/mana_en.c         | 1 +
>  drivers/net/ethernet/stmicro/stmmac/stmmac.h          | 1 +
>  drivers/net/ethernet/ti/cpsw_priv.h                   | 1 +
>  drivers/net/hyperv/hyperv_net.h                       | 1 +
>  drivers/net/tap.c                                     | 1 +
>  include/net/mana/mana.h                               | 2 ++
>  16 files changed, 17 insertions(+)
> 
[...]
> diff --git a/drivers/net/ethernet/freescale/fec.h
> b/drivers/net/ethernet/freescale/fec.h
> index 8f1edcca96c4..5a0974e62f99 100644
> --- a/drivers/net/ethernet/freescale/fec.h
> +++ b/drivers/net/ethernet/freescale/fec.h
> @@ -22,6 +22,7 @@
>  #include <linux/timecounter.h>
>  #include <dt-bindings/firmware/imx/rsrc.h>  #include
> <linux/firmware/imx/sci.h>
> +#include <net/xdp.h>
> 
>  #if defined(CONFIG_M523x) || defined(CONFIG_M527x) ||
> defined(CONFIG_M528x) || \
>      defined(CONFIG_M520x) || defined(CONFIG_M532x) ||
> defined(CONFIG_ARM) || \ diff --git

For fec.h, it looks good to me.
Reviewed-by: Wei Fang <wei.fang@....com>