netdev - Re: [PATCH v1 01/11] selftests: forwarding: custom_multipath_hash.sh: add cleanup for SIGTERM sent by timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ed25e9f5-c98c-4c72-b3f3-6db7bf395459@alu.unizg.hr>
Date: Wed, 2 Aug 2023 13:06:57 +0200
From: Mirsad Todorovac <mirsad.todorovac@....unizg.hr>
To: Petr Machata <petrm@...dia.com>
Cc: Ido Schimmel <idosch@...sch.org>, razor@...ckwall.org,
 Ido Schimmel <idosch@...dia.com>, netdev@...r.kernel.org,
 linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Shuah Khan <shuah@...nel.org>
Subject: Re: [PATCH v1 01/11] selftests: forwarding: custom_multipath_hash.sh:
 add cleanup for SIGTERM sent by timeout

On 2.8.2023. 12:33, Petr Machata wrote:
> 
> Mirsad Todorovac <mirsad.todorovac@....unizg.hr> writes:
> 
>> On 8/1/23 13:08, Petr Machata wrote:
>>> diff --git a/tools/testing/selftests/net/forwarding/mirror_gre_changes.sh
>>> b/tools/testing/selftests/net/forwarding/mirror_gre_changes.sh
>>> index aff88f78e339..5ea9d63915f7 100755
>>> --- a/tools/testing/selftests/net/forwarding/mirror_gre_changes.sh
>>> +++ b/tools/testing/selftests/net/forwarding/mirror_gre_changes.sh
>>> @@ -72,7 +72,8 @@ test_span_gre_ttl()
>>>      	RET=0
>>>    -	mirror_install $swp1 ingress $tundev "matchall $tcflags"
>>> +	mirror_install $swp1 ingress $tundev \
>>> +		"prot ip flower $tcflags ip_prot icmp"
>>>    	tc filter add dev $h3 ingress pref 77 prot $prot \
>>>    		flower skip_hw ip_ttl 50 action pass
>>>    
>>
>> The problem seems to be fixed in the test run:
>>
>> root@...iant:tools/testing/selftests/net/forwarding# ./mirror_gre_changes.sh
>> TEST: mirror to gretap: TTL change (skip_hw)                        [ OK ]
>> TEST: mirror to ip6gretap: TTL change (skip_hw)                     [ OK ]
>> TEST: mirror to gretap: tunnel down/up (skip_hw)                    [ OK ]
>> TEST: mirror to ip6gretap: tunnel down/up (skip_hw)                 [ OK ]
>> TEST: mirror to gretap: egress down/up (skip_hw)                    [ OK ]
>> TEST: mirror to ip6gretap: egress down/up (skip_hw)                 [ OK ]
>> TEST: mirror to gretap: remote address change (skip_hw)             [ OK ]
>> TEST: mirror to ip6gretap: remote address change (skip_hw)          [ OK ]
>> TEST: mirror to gretap: tunnel deleted (skip_hw)                    [ OK ]
>> TEST: mirror to ip6gretap: tunnel deleted (skip_hw)                 [ OK ]
>> TEST: mirror to gretap: underlay route removal (skip_hw)            [ OK ]
>> TEST: mirror to ip6gretap: underlay route removal (skip_hw)         [ OK ]
>> WARN: Could not test offloaded functionality
>> root@...iant:tools/testing/selftests/net/forwarding#
> 
> OK, I'll add your Tested-by, let it pass through our regression and send
> upstream.

Great stuff.

Though, all these were incompatibilities in the testing scripts, not really a bug
in the kernel proper ...

Have a nice day!

Mirsad

-- 
Mirsad Todorovac
System engineer
Faculty of Graphic Arts | Academy of Fine Arts
University of Zagreb
Republic of Croatia, the European Union

Sistem inženjer
Grafički fakultet | Akademija likovnih umjetnosti
Sveučilište u Zagrebu