netdev - Re: [PATCH net-next] ila: Remove unnecessary file net/ila.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZMpFhVtxHjP+GHq3@lincoln>
Date: Wed, 2 Aug 2023 14:01:09 +0200
From: Larysa Zaremba <larysa.zaremba@...el.com>
To: Yue Haibing <yuehaibing@...wei.com>
CC: <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
	<pabeni@...hat.com>, <dsahern@...nel.org>, <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] ila: Remove unnecessary file net/ila.h

On Tue, Aug 01, 2023 at 10:31:29PM +0800, Yue Haibing wrote:
> Commit 642c2c95585d ("ila: xlat changes") removed ila_xlat_outgoing()
> and ila_xlat_incoming() functions, then this file became unnecessary.
> 
> Signed-off-by: Yue Haibing <yuehaibing@...wei.com>

Reviewed-by: Larysa Zaremba <larysa.zaremba@...el.com>

> ---
>  include/net/ila.h       | 16 ----------------
>  net/ipv6/ila/ila_main.c |  1 -
>  net/ipv6/ila/ila_xlat.c |  1 -
>  3 files changed, 18 deletions(-)
>  delete mode 100644 include/net/ila.h
> 
> diff --git a/include/net/ila.h b/include/net/ila.h
> deleted file mode 100644
> index 73ebe5eab272..000000000000
> --- a/include/net/ila.h
> +++ /dev/null
> @@ -1,16 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0-or-later */
> -/*
> - * ILA kernel interface
> - *
> - * Copyright (c) 2015 Tom Herbert <tom@...bertland.com>
> - */
> -
> -#ifndef _NET_ILA_H
> -#define _NET_ILA_H
> -
> -struct sk_buff;
> -
> -int ila_xlat_outgoing(struct sk_buff *skb);
> -int ila_xlat_incoming(struct sk_buff *skb);
> -
> -#endif /* _NET_ILA_H */
> diff --git a/net/ipv6/ila/ila_main.c b/net/ipv6/ila/ila_main.c
> index 3faf62530d6a..69caed07315f 100644
> --- a/net/ipv6/ila/ila_main.c
> +++ b/net/ipv6/ila/ila_main.c
> @@ -1,6 +1,5 @@
>  // SPDX-License-Identifier: GPL-2.0
>  #include <net/genetlink.h>
> -#include <net/ila.h>
>  #include <net/netns/generic.h>
>  #include <uapi/linux/genetlink.h>
>  #include "ila.h"
> diff --git a/net/ipv6/ila/ila_xlat.c b/net/ipv6/ila/ila_xlat.c
> index bee45dfeb187..67e8c9440977 100644
> --- a/net/ipv6/ila/ila_xlat.c
> +++ b/net/ipv6/ila/ila_xlat.c
> @@ -5,7 +5,6 @@
>  #include <linux/rhashtable.h>
>  #include <linux/vmalloc.h>
>  #include <net/genetlink.h>
> -#include <net/ila.h>
>  #include <net/netns/generic.h>
>  #include <uapi/linux/genetlink.h>
>  #include "ila.h"
> -- 
> 2.34.1
> 
>