netdev - Re: [PATCH net-next] sctp: Remove unused function declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 2 Aug 2023 09:44:17 -0400
From: Xin Long <lucien.xin@...il.com>
To: Yue Haibing <yuehaibing@...wei.com>
Cc: marcelo.leitner@...il.com, davem@...emloft.net, edumazet@...gle.com, 
	kuba@...nel.org, pabeni@...hat.com, linux-sctp@...r.kernel.org, 
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] sctp: Remove unused function declarations

On Mon, Jul 31, 2023 at 10:10 AM Yue Haibing <yuehaibing@...wei.com> wrote:
>
> These declarations are never implemented since beginning of git history.
>
> Signed-off-by: Yue Haibing <yuehaibing@...wei.com>
> ---
>  include/net/sctp/sm.h      | 3 ---
>  include/net/sctp/structs.h | 2 --
>  2 files changed, 5 deletions(-)
>
> diff --git a/include/net/sctp/sm.h b/include/net/sctp/sm.h
> index f37c7a558d6d..64c42bd56bb2 100644
> --- a/include/net/sctp/sm.h
> +++ b/include/net/sctp/sm.h
> @@ -156,7 +156,6 @@ sctp_state_fn_t sctp_sf_do_6_2_sack;
>  sctp_state_fn_t sctp_sf_autoclose_timer_expire;
>
>  /* Prototypes for utility support functions.  */
> -__u8 sctp_get_chunk_type(struct sctp_chunk *chunk);
>  const struct sctp_sm_table_entry *sctp_sm_lookup_event(
>                                         struct net *net,
>                                         enum sctp_event_type event_type,
> @@ -166,8 +165,6 @@ int sctp_chunk_iif(const struct sctp_chunk *);
>  struct sctp_association *sctp_make_temp_asoc(const struct sctp_endpoint *,
>                                              struct sctp_chunk *,
>                                              gfp_t gfp);
> -__u32 sctp_generate_verification_tag(void);
> -void sctp_populate_tie_tags(__u8 *cookie, __u32 curTag, __u32 hisTag);
>
>  /* Prototypes for chunk-building functions.  */
>  struct sctp_chunk *sctp_make_init(const struct sctp_association *asoc,
> diff --git a/include/net/sctp/structs.h b/include/net/sctp/structs.h
> index 5c72d1864dd6..5a24d6d8522a 100644
> --- a/include/net/sctp/structs.h
> +++ b/include/net/sctp/structs.h
> @@ -1122,8 +1122,6 @@ void sctp_outq_free(struct sctp_outq*);
>  void sctp_outq_tail(struct sctp_outq *, struct sctp_chunk *chunk, gfp_t);
>  int sctp_outq_sack(struct sctp_outq *, struct sctp_chunk *);
>  int sctp_outq_is_empty(const struct sctp_outq *);
> -void sctp_outq_restart(struct sctp_outq *);
> -
>  void sctp_retransmit(struct sctp_outq *q, struct sctp_transport *transport,
>                      enum sctp_retransmit_reason reason);
>  void sctp_retransmit_mark(struct sctp_outq *, struct sctp_transport *, __u8);
> --
> 2.34.1
>
Acked-by: Xin Long <lucien.xin@...il.com>