netdev - Re: [PATCH iproute2-next] bridge: Add backup nexthop ID support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 2 Aug 2023 20:22:29 +0300
From: Ido Schimmel <idosch@...sch.org>
To: David Ahern <dsahern@...il.com>
Cc: Petr Machata <petrm@...dia.com>, Ido Schimmel <idosch@...dia.com>,
	netdev@...r.kernel.org, stephen@...workplumber.org,
	razor@...ckwall.org
Subject: Re: [PATCH iproute2-next] bridge: Add backup nexthop ID support

On Wed, Aug 02, 2023 at 09:35:12AM -0600, David Ahern wrote:
> ugh, please send a fix.

Will send a fix tomorrow. Seems to be fixed by [1], but we might need
something similar for the bucket dump.

[1]
diff --git a/net/ipv4/nexthop.c b/net/ipv4/nexthop.c
index 93f14d39fef6..1bd92acbc6c5 100644
--- a/net/ipv4/nexthop.c
+++ b/net/ipv4/nexthop.c
@@ -3170,7 +3170,7 @@ static int nh_valid_dump_req(const struct nlmsghdr *nlh,
 }
 
 struct rtm_dump_nh_ctx {
-       u32 idx;
+       u64 idx;
 };
 
 static struct rtm_dump_nh_ctx *
@@ -3192,7 +3192,7 @@ static int rtm_dump_walk_nexthops(struct sk_buff *skb,
                                  void *data)
 {
        struct rb_node *node;
-       int s_idx;
+       u64 s_idx;
        int err;
 
        s_idx = ctx->idx;