netdev - Re: [PATCH net v1 1/2] netlink: let len field used to parse type-not-care nested attrs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230801175338.74bc39c2@kernel.org>
Date: Tue, 1 Aug 2023 17:53:38 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: "Lin Ma" <linma@....edu.cn>
Cc: "Leon Romanovsky" <leon@...nel.org>, davem@...emloft.net,
 edumazet@...gle.com, pabeni@...hat.com, fw@...len.de,
 yang.lee@...ux.alibaba.com, jgg@...pe.ca, markzhang@...dia.com,
 phaddad@...dia.com, yuancan@...wei.com, ohartoov@...dia.com,
 chenzhongjin@...wei.com, aharonl@...dia.com, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-rdma@...r.kernel.org
Subject: Re: [PATCH net v1 1/2] netlink: let len field used to parse
 type-not-care nested attrs

On Wed, 2 Aug 2023 08:26:06 +0800 (GMT+08:00) Lin Ma wrote:
> This is true. Actually, those check missing codes are mostly old codes and
> modern netlink consumers will choose the general netlink interface which
> can automatically get attributes description from YAML and never need to
> do things like *manual parsing* anymore.
> 
> However, according to my practice in auditing the code, I found there are
> some general netlink interface users confront other issues like choosing
> GENL_DONT_VALIDATE_STRICT without thinking or forgetting add a new
> nla_policy when introducing new attributes.
> 
> To this end, I'm currently writing a simple documentation about Netlink
> interface best practices for the kernel developer (the newly coming docs
> are mostly about the user API part). 

Keep in mind that even most of the genetlink stuff is pretty old
at this stage. ethtool is probably the first reasonably modern family.
But do send docs, we'll review and go from there :)