netdev - Re: [PATCH] mISDN: Update parameter type of dsp_cmx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABCJKud-ve+6v5h1QeDwUm4q7XzuhMorDTwAGmsV4h-R+0MKxg@mail.gmail.com>
Date: Wed, 2 Aug 2023 10:54:47 -0700
From: Sami Tolvanen <samitolvanen@...gle.com>
To: Nathan Chancellor <nathan@...nel.org>
Cc: isdn@...ux-pingi.de, netdev@...r.kernel.org, keescook@...omium.org, 
	llvm@...ts.linux.dev, patches@...ts.linux.dev, 
	kernel test robot <oliver.sang@...el.com>
Subject: Re: [PATCH] mISDN: Update parameter type of dsp_cmx_send()

Hi Nathan,

On Wed, Aug 2, 2023 at 10:40 AM Nathan Chancellor <nathan@...nel.org> wrote:
>
> When booting a kernel with CONFIG_MISDN_DSP=y and CONFIG_CFI_CLANG=y,
> there is a failure when dsp_cmx_send() is called indirectly from
> call_timer_fn():
>
>   [    0.371412] CFI failure at call_timer_fn+0x2f/0x150 (target: dsp_cmx_send+0x0/0x530; expected type: 0x92ada1e9)
>
> The function pointer prototype that call_timer_fn() expects is
>
>   void (*fn)(struct timer_list *)
>
> whereas dsp_cmx_send() has a parameter type of 'void *', which causes
> the control flow integrity checks to fail because the parameter types do
> not match.
>
> Change dsp_cmx_send()'s parameter type to be 'struct timer_list' to
> match the expected prototype. The argument is unused anyways, so this
> has no functional change, aside from avoiding the CFI failure.

Looks correct to me, thanks for fixing this!

Reviewed-by: Sami Tolvanen <samitolvanen@...gle.com>

Sami