netdev - Re: [PATCH bpf-next 0/3] net: struct netdev_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAADnVQJdA25VBE+7Erw7-beL4+=fy1KtRA3ojN0o1yUztnyjjw@mail.gmail.com>
Date: Tue, 1 Aug 2023 19:31:25 -0700
From: Alexei Starovoitov <alexei.starovoitov@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Alexei Starovoitov <ast@...nel.org>, Network Development <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>, 
	Jesper Dangaard Brouer <hawk@...nel.org>, Amritha Nambiar <amritha.nambiar@...el.com>, 
	Alexander Lobakin <aleksander.lobakin@...el.com>
Subject: Re: [PATCH bpf-next 0/3] net: struct netdev_rx_queue and xdp.h reshuffling

On Tue, Aug 1, 2023 at 5:33 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> While poking at struct netdev_rx_queue I got annoyed by
> the huge rebuild times. I split it out from netdevice.h
> and then realized that it was the main reason we included
> xdp.h in there. So I removed that dependency as well.
>
> This gives us very pleasant build times for both xdp.h
> and struct netdev_rx_queue changes.
>
> I'm sending this for bpf-next because I think it'd be easiest
> if it goes in there, and then bpf-next gets flushed soon after?
> I can also make a branch on merge-base for net-next and bpf-next..

Sounds like a plan to me.
Especially considering that targeting bpf-next will exercise BPF CI...
and it's not happy at the moment:
../net/netfilter/nf_conntrack_bpf.c: In function ‘bpf_xdp_ct_alloc’:
../net/netfilter/nf_conntrack_bpf.c:258:44: error: dereferencing
pointer to incomplete type ‘struct xdp_buff’
258 | nfct = __bpf_nf_ct_alloc_entry(dev_net(ctx->rxq->dev),
bpf_tuple, tuple__sz,
|