netdev - Re: [EXTERNAL] Re: [PATCH V7 net] net: mana: Fix MANA VF unload when hardware is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH-L+nPsuoJfCQcJnpMWk5DPGev8f+YWi0K4V+fU=5-bxP5GVw@mail.gmail.com>
Date: Wed, 2 Aug 2023 10:57:52 +0530
From: Kalesh Anakkur Purayil <kalesh-anakkur.purayil@...adcom.com>
To: Souradeep Chakrabarti <schakrabarti@...rosoft.com>
Cc: Simon Horman <horms@...nel.org>, 
	Souradeep Chakrabarti <schakrabarti@...ux.microsoft.com>, KY Srinivasan <kys@...rosoft.com>, 
	Haiyang Zhang <haiyangz@...rosoft.com>, "wei.liu@...nel.org" <wei.liu@...nel.org>, 
	Dexuan Cui <decui@...rosoft.com>, "davem@...emloft.net" <davem@...emloft.net>, 
	"edumazet@...gle.com" <edumazet@...gle.com>, "kuba@...nel.org" <kuba@...nel.org>, 
	"pabeni@...hat.com" <pabeni@...hat.com>, Long Li <longli@...rosoft.com>, 
	Ajay Sharma <sharmaajay@...rosoft.com>, "leon@...nel.org" <leon@...nel.org>, 
	"cai.huoqing@...ux.dev" <cai.huoqing@...ux.dev>, 
	"ssengar@...ux.microsoft.com" <ssengar@...ux.microsoft.com>, vkuznets <vkuznets@...hat.com>, 
	"tglx@...utronix.de" <tglx@...utronix.de>, 
	"linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>, 
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, 
	"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>, 
	"stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: Re: [EXTERNAL] Re: [PATCH V7 net] net: mana: Fix MANA VF unload when
 hardware is

Hi Souradeep,

It looks like the subject line is not complete. I could see "net: mana: Fix
MANA VF unload when hardware is".

Is that correct?

Regards,
Kalesh

On Wed, Aug 2, 2023 at 12:29 AM Souradeep Chakrabarti <
schakrabarti@...rosoft.com> wrote:

>
>
> >-----Original Message-----
> >From: Simon Horman <horms@...nel.org>
> >Sent: Tuesday, August 1, 2023 9:01 PM
> >To: Souradeep Chakrabarti <schakrabarti@...ux.microsoft.com>
> >Cc: KY Srinivasan <kys@...rosoft.com>; Haiyang Zhang
> ><haiyangz@...rosoft.com>; wei.liu@...nel.org; Dexuan Cui
> ><decui@...rosoft.com>; davem@...emloft.net; edumazet@...gle.com;
> >kuba@...nel.org; pabeni@...hat.com; Long Li <longli@...rosoft.com>; Ajay
> >Sharma <sharmaajay@...rosoft.com>; leon@...nel.org;
> >cai.huoqing@...ux.dev; ssengar@...ux.microsoft.com; vkuznets
> ><vkuznets@...hat.com>; tglx@...utronix.de; linux-hyperv@...r.kernel.org;
> >netdev@...r.kernel.org; linux-kernel@...r.kernel.org; linux-
> >rdma@...r.kernel.org; Souradeep Chakrabarti
> ><schakrabarti@...rosoft.com>; stable@...r.kernel.org
> >Subject: [EXTERNAL] Re: [PATCH V7 net] net: mana: Fix MANA VF unload when
> >hardware is
> >
> >On Tue, Aug 01, 2023 at 05:29:13AM -0700, Souradeep Chakrabarti wrote:
> >
> >...
> >
> >Hi Souradeep,
> >
> >
> >> +    for (i = 0; i < apc->num_queues; i++) {
> >> +            txq = &apc->tx_qp[i].txq;
> >> +            while (skb = skb_dequeue(&txq->pending_skbs)) {
> >
> >W=1 builds with both clang-16 and gcc-12 complain that they would like an
> >extra set of parentheses around an assignment used as a truth value.
> Thanks for letting me know. I will fix it in next version.
> >
> >> +                    mana_unmap_skb(skb, apc);
> >> +                    dev_consume_skb_any(skb);
> >> +            }
> >> +            atomic_set(&txq->pending_sends, 0);
> >> +    }
> >>      /* We're 100% sure the queues can no longer be woken up, because
> >>       * we're sure now mana_poll_tx_cq() can't be running.
> >>       */
> >> --
> >> 2.34.1
> >>
> >>
>
>

-- 
Regards,
Kalesh A P

Content of type "text/html" skipped

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4239 bytes)