netdev - Re: [PATCH 2/5] mmc: au1xmmc: force non-modular build and remove symbol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 2 Aug 2023 09:12:37 +0200
From: Manuel Lauss <manuel.lauss@...il.com>
To: Christoph Hellwig <hch@....de>
Cc: Luis Chamberlain <mcgrof@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Daniel Mack <daniel@...que.org>, Haojian Zhuang <haojian.zhuang@...il.com>, 
	Robert Jarzmik <robert.jarzmik@...e.fr>, Ulf Hansson <ulf.hansson@...aro.org>, 
	Yangbo Lu <yangbo.lu@....com>, Joshua Kinard <kumba@...too.org>, 
	Daniel Vetter <daniel.vetter@...ll.ch>, Arnd Bergmann <arnd@...db.de>, 
	linux-arm-kernel@...ts.infradead.org, 
	open list <linux-kernel@...r.kernel.org>, linux-mmc@...r.kernel.org, 
	netdev@...r.kernel.org, linux-rtc@...r.kernel.org, 
	linux-modules@...r.kernel.org
Subject: Re: [PATCH 2/5] mmc: au1xmmc: force non-modular build and remove
 symbol_get usage

On Tue, Aug 1, 2023 at 7:36 PM Christoph Hellwig <hch@....de> wrote:
>
> au1xmmc is split somewhat awkwardly into the main mmc subsystem driver,
> and callbacks in platform_data that sit under arch/mips/ and are
> always built in.  The latter than call mmc_detect_change through
> symbol_get.  Remove the use of symbol_get by requiring the driver
> to be built in.  In the future the interrupt handlers for card
> insert/eject detection should probably be moved into the main driver,
> and which point it can be built modular again.

The carddetection stuff is entirely system-specific, I don't want the driver
littered with board-custom stuff; I'm fine with it being built-in only.


> Signed-off-by: Christoph Hellwig <hch@....de>
> ---
>  arch/mips/alchemy/devboards/db1000.c |  8 +-------
>  arch/mips/alchemy/devboards/db1200.c | 19 ++-----------------
>  arch/mips/alchemy/devboards/db1300.c | 10 +---------
>  drivers/mmc/host/Kconfig             |  4 ++--
>  4 files changed, 6 insertions(+), 35 deletions(-)

Ok For me.  If it matters:

Acked-by: Manuel Lauss <manuel.lauss@...il.com>

Thanks!
     Manuel