netdev - Re: [net-next 2/2] selftests: seg6: add selftest for NEXT-C-SID flavor in SRv6 End.X behavior

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9916825da00d375a33abdcb0aa773c5520a307e1.camel@redhat.com>
Date: Thu, 03 Aug 2023 10:07:14 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Andrea Mayer <andrea.mayer@...roma2.it>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
 <kuba@...nel.org>, David Ahern <dsahern@...nel.org>, Shuah Khan
 <shuah@...nel.org>,  linux-kernel@...r.kernel.org, netdev@...r.kernel.org, 
 linux-kselftest@...r.kernel.org
Cc: Stefano Salsano <stefano.salsano@...roma2.it>, Paolo Lungaroni
	 <paolo.lungaroni@...roma2.it>, Ahmed Abdelsalam <ahabdels.dev@...il.com>, 
	Hangbin Liu <liuhangbin@...il.com>
Subject: Re: [net-next 2/2] selftests: seg6: add selftest for NEXT-C-SID
 flavor in SRv6 End.X behavior

On Mon, 2023-07-31 at 19:51 +0200, Andrea Mayer wrote:
> From: Paolo Lungaroni <paolo.lungaroni@...roma2.it>
> 
> This selftest is designed for testing the support of NEXT-C-SID flavor
> for SRv6 End.X behavior. It instantiates a virtual network composed of
> several nodes: hosts and SRv6 routers. Each node is realized using a
> network namespace that is properly interconnected to others through veth
> pairs, according to the topology depicted in the selftest script file.
> The test considers SRv6 routers implementing IPv4/IPv6 L3 VPNs leveraged
> by hosts for communicating with each other. Such routers i) apply
> different SRv6 Policies to the traffic received from connected hosts,
> considering the IPv4 or IPv6 protocols; ii) use the NEXT-C-SID
> compression mechanism for encoding several SRv6 segments within a single
> 128-bit SID address, referred to as a Compressed SID (C-SID) container.
> 
> The NEXT-C-SID is provided as a "flavor" of the SRv6 End.X behavior,
> enabling it to properly process the C-SID containers. The correct
> execution of the enabled NEXT-C-SID SRv6 End.X behavior is verified
> through reachability tests carried out between hosts belonging to the
> same VPN.
> 
> Signed-off-by: Andrea Mayer <andrea.mayer@...roma2.it>
> Signed-off-by: Paolo Lungaroni <paolo.lungaroni@...roma2.it>

The patches LGTM, but there is a minor issues WRT the tag area. Since
this patch contains a

From: Paolo Lungaroni <paolo.lungaroni@...roma2.it>

tag, Paolo's sob should come first.

According to the the newly created shell script comments, it looks like
the patch as been co developed by both Paolo abd Andrea.

In that case the correct tag sequence would be:

SoB Paolo
Co-devel Andrea
SoB Andrea

Since the above is relevant for correct patch authorship attribution I
suggest to address that in a new revision.

BTW, I a really appreciate the descriptive-but-not-too-verbose commit
message!

Thanks,

Paolo